Skip to content

safer wasm cache key#4799

Merged
mergify[bot] merged 2 commits intomainfrom
tomas/safer-wasm-cache-key
Sep 6, 2025
Merged

safer wasm cache key#4799
mergify[bot] merged 2 commits intomainfrom
tomas/safer-wasm-cache-key

Conversation

@tzemanovic
Copy link
Copy Markdown
Collaborator

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@tzemanovic tzemanovic force-pushed the tomas/safer-wasm-cache-key branch from ed843ab to a999a4d Compare September 6, 2025 08:07
@tzemanovic tzemanovic force-pushed the tomas/safer-wasm-cache-key branch from a999a4d to 2fab3b6 Compare September 6, 2025 08:11
@tzemanovic tzemanovic changed the base branch from maint-201.0 to main September 6, 2025 08:11
@tzemanovic tzemanovic changed the title safer wasm cache key (maint apps v201) safer wasm cache key Sep 6, 2025
@tzemanovic tzemanovic added the backport-201.0 Backport to app 201.0 maintenance branch label Sep 6, 2025
@tzemanovic tzemanovic marked this pull request as ready for review September 6, 2025 08:13
@Fraccaman Fraccaman self-requested a review September 6, 2025 08:20
@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Sep 6, 2025
@tzemanovic tzemanovic added merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass backport-libs-0.251 Backport libraries to 0.251 maintenance branch and removed backport-libs-0.251 Backport libraries to 0.251 maintenance branch labels Sep 6, 2025
Copy link
Copy Markdown
Collaborator

@sug0 sug0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

here's an alternative approach that works even if no .git repo is present: you compute a hash digest of the entire project directory's contents. this way, you always get a unique identifier for your cache keys, if the source code ever changes

@tzemanovic
Copy link
Copy Markdown
Collaborator Author

lgtm

here's an alternative approach that works even if no .git repo is present: you compute a hash digest of the entire project directory's contents. this way, you always get a unique identifier for your cache keys, if the source code ever changes

I think only time .git is not present is when we're publishing to crates.io, for which we'll have a unique pkg version so the fallback should handle it

@tzemanovic tzemanovic marked this pull request as draft September 6, 2025 11:16
@tzemanovic tzemanovic marked this pull request as ready for review September 6, 2025 11:16
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Sep 6, 2025

🧪 CI Insights

Here's what we observed from your CI run for 3946965.

✅ Passed Jobs With Interesting Signals

Pipeline Job Signal Health on main Retries 🔍 CI Insights 📄 Logs
Lint 🧹 Build 🛠️ Test 🚦 build-binaries Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
check-benchmarks Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
test-e2e-with-device-automation Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
test-integration Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
test-unit Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View
test-wasm Base branch is broken, but the job passed. Looks like this might be a real fix 💪 Broken 0 View View

mergify bot added a commit that referenced this pull request Sep 6, 2025
@mergify mergify bot merged commit 15750b6 into main Sep 6, 2025
46 of 47 checks passed
@mergify mergify bot deleted the tomas/safer-wasm-cache-key branch September 6, 2025 12:43
mergify bot pushed a commit that referenced this pull request Sep 6, 2025
(cherry picked from commit 3946965)
mergify bot pushed a commit that referenced this pull request Sep 6, 2025
(cherry picked from commit 3946965)
mergify bot added a commit that referenced this pull request Sep 6, 2025
mergify bot added a commit that referenced this pull request Sep 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-201.0 Backport to app 201.0 maintenance branch backport-libs-0.251 Backport libraries to 0.251 maintenance branch merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants