account!: Revert "account: Temporarily revert breaking changes (#549)" (#552)

Revert "account: Temporarily revert breaking changes (#549)"

This reverts commit bbd57d4.

Author: joncinque

account/src/lib.rs

@@ -204,14 +204,6 @@ pub trait WritableAccount: ReadableAccount {
     fn copy_into_owner_from_slice(&mut self, source: &[u8]);
     fn set_executable(&mut self, executable: bool);
     fn set_rent_epoch(&mut self, epoch: Epoch);
-    #[deprecated(since = "3.3.0")]
-    fn create(
-        lamports: u64,
-        data: Vec<u8>,
-        owner: Pubkey,
-        executable: bool,
-        rent_epoch: Epoch,
-    ) -> Self;
 }
 
 pub trait ReadableAccount: Sized {
@@ -220,17 +212,6 @@ pub trait ReadableAccount: Sized {
     fn owner(&self) -> &Pubkey;
     fn executable(&self) -> bool;
     fn rent_epoch(&self) -> Epoch;
-    #[deprecated(since = "3.2.0")]
-    fn to_account_shared_data(&self) -> AccountSharedData {
-        #[allow(deprecated)]
-        AccountSharedData::create(
-            self.lamports(),
-            self.data().to_vec(),
-            *self.owner(),
-            self.executable(),
-            self.rent_epoch(),
-        )
-    }
 }
 
 impl<T> ReadableAccount for T
@@ -292,21 +273,6 @@ impl WritableAccount for Account {
     fn set_rent_epoch(&mut self, epoch: Epoch) {
         self.rent_epoch = epoch;
     }
-    fn create(
-        lamports: u64,
-        data: Vec<u8>,
-        owner: Pubkey,
-        executable: bool,
-        rent_epoch: Epoch,
-    ) -> Self {
-        Account {
-            lamports,
-            data,
-            owner,
-            executable,
-            rent_epoch,
-        }
-    }
 }
 
 impl WritableAccount for AccountSharedData {
@@ -328,21 +294,6 @@ impl WritableAccount for AccountSharedData {
     fn set_rent_epoch(&mut self, epoch: Epoch) {
         self.rent_epoch = epoch;
     }
-    fn create(
-        lamports: u64,
-        data: Vec<u8>,
-        owner: Pubkey,
-        executable: bool,
-        rent_epoch: Epoch,
-    ) -> Self {
-        AccountSharedData {
-            lamports,
-            data: Arc::new(data),
-            owner,
-            executable,
-            rent_epoch,
-        }
-    }
 }
 
 impl ReadableAccount for AccountSharedData {
@@ -361,10 +312,6 @@ impl ReadableAccount for AccountSharedData {
     fn rent_epoch(&self) -> Epoch {
         self.rent_epoch
     }
-    fn to_account_shared_data(&self) -> AccountSharedData {
-        // avoid data copy here
-        self.clone()
-    }
 }
 
 fn debug_fmt<T: ReadableAccount>(item: &T, f: &mut fmt::Formatter<'_>) -> fmt::Result {
@@ -845,18 +792,6 @@ pub mod tests {
         account2.serialize_data(&"hello world").unwrap();
     }
 
-    #[test]
-    #[allow(deprecated)]
-    fn test_to_account_shared_data() {
-        let key = Pubkey::new_unique();
-        let (account1, account2) = make_two_accounts(&key);
-        assert!(accounts_equal(&account1, &account2));
-        let account3 = account1.to_account_shared_data();
-        let account4 = account2.to_account_shared_data();
-        assert!(accounts_equal(&account1, &account3));
-        assert!(accounts_equal(&account1, &account4));
-    }
-
     #[test]
     fn test_account_shared_data() {
         let key = Pubkey::new_unique();