hashtable: fix infinite loop

Lior Amram · Lior Amram · commit dd866724173b · 2014-05-05T11:47:03.000-07:00
diff --git a/src/hashtable.c b/src/hashtable.c
@@ -244,11 +244,10 @@ uint32_t hashtable_lookup_insert(struct hashtable *ht, const void *key, size_t k
             union hashtable_internal_rec *rec = _HASHTABLE_REC(e->rec);
             if (rec->rec.key_size == key_len && 0 == memcmp(key, rec->rec.data, key_len))
                 return e->rec;
-        } else {
-            ++bucket;
-            if (bucket > mask)
-                bucket = 0;
         }
+        ++bucket;
+        if (bucket > mask)
+            bucket = 0;
     }
     return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -244,11 +244,10 @@ uint32_t hashtable_lookup_insert(struct hashtable ht, const void key, size_t k`
`244`	`244`	`union hashtable_internal_rec *rec = _HASHTABLE_REC(e->rec);`
`245`	`245`	`if (rec->rec.key_size == key_len && 0 == memcmp(key, rec->rec.data, key_len))`
`246`	`246`	`return e->rec;`
`247`		`- } else {`
`248`		`- ++bucket;`
`249`		`- if (bucket > mask)`
`250`		`- bucket = 0;`
`251`	`247`	`}`
	`248`	`+ ++bucket;`
	`249`	`+ if (bucket > mask)`
	`250`	`+ bucket = 0;`
`252`	`251`	`}`
`253`	`252`	`return 0;`
`254`	`253`	`}`