From 5039da59c9e4e473fd6c0e194bc21a0e94b00d8c Mon Sep 17 00:00:00 2001 From: austin Date: Tue, 24 Oct 2023 18:00:52 +0000 Subject: [PATCH 1/3] fix: set dry_run to be optional. --- .../schemas/task_instance_schema.py | 2 +- .../schemas/test_task_instance_schema.py | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/airflow/api_connexion/schemas/task_instance_schema.py b/airflow/api_connexion/schemas/task_instance_schema.py index 02dc1fb3f6fa6..c9084151d88ef 100644 --- a/airflow/api_connexion/schemas/task_instance_schema.py +++ b/airflow/api_connexion/schemas/task_instance_schema.py @@ -155,7 +155,7 @@ def validate_form(self, data, **kwargs): class SetTaskInstanceStateFormSchema(Schema): """Schema for handling the request of setting state of task instance of a DAG.""" - dry_run = fields.Boolean(dump_default=True) + dry_run = fields.Boolean(load_default=True) task_id = fields.Str(required=True) execution_date = fields.DateTime(validate=validate_istimezone) dag_run_id = fields.Str() diff --git a/tests/api_connexion/schemas/test_task_instance_schema.py b/tests/api_connexion/schemas/test_task_instance_schema.py index e46d0f8a5b272..5328941ca8a81 100644 --- a/tests/api_connexion/schemas/test_task_instance_schema.py +++ b/tests/api_connexion/schemas/test_task_instance_schema.py @@ -236,6 +236,22 @@ def test_success(self): } assert expected_result == result + def test_dry_run_is_optional(self): + data = self.current_input.copy() + data.pop("dry_run") + result = set_task_instance_state_form.load(self.current_input) + expected_result = { + "dry_run": True, + "execution_date": dt.datetime(2020, 1, 1, 0, 0, tzinfo=dt.timezone(dt.timedelta(0), "+0000")), + "include_downstream": True, + "include_future": True, + "include_past": True, + "include_upstream": True, + "new_state": "failed", + "task_id": "print_the_context", + } + assert expected_result == result + @pytest.mark.parametrize( "override_data", [ From ac206f65f59166a87f2d340dd19888ed144be6d4 Mon Sep 17 00:00:00 2001 From: Elad Kalif <45845474+eladkal@users.noreply.github.com> Date: Fri, 27 Oct 2023 20:24:10 +0300 Subject: [PATCH 2/3] Update tests/api_connexion/schemas/test_task_instance_schema.py --- tests/api_connexion/schemas/test_task_instance_schema.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/api_connexion/schemas/test_task_instance_schema.py b/tests/api_connexion/schemas/test_task_instance_schema.py index 5328941ca8a81..3a79f30e71ed3 100644 --- a/tests/api_connexion/schemas/test_task_instance_schema.py +++ b/tests/api_connexion/schemas/test_task_instance_schema.py @@ -251,7 +251,6 @@ def test_dry_run_is_optional(self): "task_id": "print_the_context", } assert expected_result == result - @pytest.mark.parametrize( "override_data", [ From 7d0687f4cfc4500914c1c71313a8f14a9af0e1f5 Mon Sep 17 00:00:00 2001 From: austin Date: Mon, 30 Oct 2023 16:15:34 +0000 Subject: [PATCH 3/3] Removed extra whitespace. --- tests/api_connexion/schemas/test_task_instance_schema.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/api_connexion/schemas/test_task_instance_schema.py b/tests/api_connexion/schemas/test_task_instance_schema.py index 5328941ca8a81..1c43ef480932e 100644 --- a/tests/api_connexion/schemas/test_task_instance_schema.py +++ b/tests/api_connexion/schemas/test_task_instance_schema.py @@ -251,7 +251,7 @@ def test_dry_run_is_optional(self): "task_id": "print_the_context", } assert expected_result == result - + @pytest.mark.parametrize( "override_data", [