From f9d8e38e92d83c620c3a4c430bf42ee91df3fdff Mon Sep 17 00:00:00 2001 From: vincbeck Date: Thu, 6 Mar 2025 15:06:57 -0500 Subject: [PATCH] Remove `is_in_fab` in FAB auth manager --- .../fab/auth_manager/fab_auth_manager.py | 16 +--------------- 1 file changed, 1 insertion(+), 15 deletions(-) diff --git a/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py b/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py index b416d31e2125f..161f1920dbc02 100644 --- a/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py +++ b/providers/fab/src/airflow/providers/fab/auth_manager/fab_auth_manager.py @@ -144,12 +144,6 @@ class FabAuthManager(BaseAuthManager[User]): appbuilder: AirflowAppBuilder | None = None - is_in_fab: bool = False - """ - Whether the instance is run in FAB or Fastapi. - Can be deleted once the Airflow 2 legacy UI is removed. - """ - def init(self) -> None: """Run operations when Airflow is initializing.""" if self.appbuilder: @@ -420,15 +414,7 @@ def security_manager(self) -> FabAirflowSecurityManagerOverride: def get_url_login(self, **kwargs) -> str: """Return the login page url.""" - if self.is_in_fab: - if not self.security_manager.auth_view: - raise AirflowException("`auth_view` not defined in the security manager.") - if next_url := kwargs.get("next_url"): - return url_for(f"{self.security_manager.auth_view.endpoint}.login", next=next_url) - else: - return url_for(f"{self.security_manager.auth_view.endpoint}.login") - else: - return f"{self.apiserver_endpoint}/auth/login" + return f"{self.apiserver_endpoint}/auth/login" def get_url_logout(self): """Return the logout page url."""