From 43d11efd30417f4ee9d9c985cacff916dc8e5b4c Mon Sep 17 00:00:00 2001 From: Xch1 Date: Tue, 30 Sep 2025 10:18:45 +0800 Subject: [PATCH 1/5] fix test_cloud_sql Signed-off-by: Xch1 --- .../google/tests/unit/google/cloud/hooks/test_cloud_sql.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/providers/google/tests/unit/google/cloud/hooks/test_cloud_sql.py b/providers/google/tests/unit/google/cloud/hooks/test_cloud_sql.py index f1a332eb4fb7a..52d1190fbc300 100644 --- a/providers/google/tests/unit/google/cloud/hooks/test_cloud_sql.py +++ b/providers/google/tests/unit/google/cloud/hooks/test_cloud_sql.py @@ -974,10 +974,10 @@ def test_cloudsql_database_hook_get_sqlproxy_runner_no_proxy(self, get_connectio hook = CloudSQLDatabaseHook( gcp_cloudsql_conn_id="cloudsql_connection", default_gcp_project_id="google_connection" ) - with pytest.raises(ValueError) as ctx: + with pytest.raises( + ValueError, match="Proxy runner can only be retrieved in case of use_proxy = True" + ): hook.get_sqlproxy_runner() - err = ctx.value - assert "Proxy runner can only be retrieved in case of use_proxy = True" in str(err) @mock.patch("airflow.providers.google.cloud.hooks.cloud_sql.CloudSQLDatabaseHook.get_connection") def test_cloudsql_database_hook_get_sqlproxy_runner(self, get_connection): From e76bd6e97ac51575ac816e6f3f015592580a618c Mon Sep 17 00:00:00 2001 From: Xch1 Date: Tue, 30 Sep 2025 10:22:07 +0800 Subject: [PATCH 2/5] fix test_cloud_logging Signed-off-by: Xch1 --- .../google/tests/unit/google/cloud/hooks/test_cloud_logging.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/providers/google/tests/unit/google/cloud/hooks/test_cloud_logging.py b/providers/google/tests/unit/google/cloud/hooks/test_cloud_logging.py index afaea5185ff97..d4d83088a008f 100644 --- a/providers/google/tests/unit/google/cloud/hooks/test_cloud_logging.py +++ b/providers/google/tests/unit/google/cloud/hooks/test_cloud_logging.py @@ -160,7 +160,7 @@ def test_create_sink_dict_input(self, mock_config_client): mock_config_client.return_value.create_sink.assert_called_once_with(request=expected_request) def test_update_sink_invalid_dict_format(self): - with pytest.raises(ValueError): + with pytest.raises(ValueError, match="Unknown field for LogSink: invalid_key"): self.hook.update_sink( sink_name=SINK_NAME, sink={"invalid_key": "value"}, From b7b512f87782ea752b0fda0ee1eba7f20c1eaef1 Mon Sep 17 00:00:00 2001 From: Xch1 Date: Tue, 30 Sep 2025 10:27:16 +0800 Subject: [PATCH 3/5] fix hooks/test_bigquery Signed-off-by: Xch1 --- .../google/tests/unit/google/cloud/hooks/test_bigquery.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/providers/google/tests/unit/google/cloud/hooks/test_bigquery.py b/providers/google/tests/unit/google/cloud/hooks/test_bigquery.py index 650eed7a0359c..9267497af3064 100644 --- a/providers/google/tests/unit/google/cloud/hooks/test_bigquery.py +++ b/providers/google/tests/unit/google/cloud/hooks/test_bigquery.py @@ -1550,11 +1550,9 @@ async def test_cancel_job_failure(self, mock_job, mock_auth_default): project_id = "test_project" location = "US" - with pytest.raises(Exception) as excinfo: + with pytest.raises(Exception, match="Cancellation failed"): await hook.cancel_job(job_id=job_id, project_id=project_id, location=location) - assert "Cancellation failed" in str(excinfo.value), "Exception message not passed correctly" - mock_job_instance.cancel.assert_called_once() @pytest.mark.asyncio From 1ab5ff248cf5dca52e82369fd9b7afca2cbcfc5f Mon Sep 17 00:00:00 2001 From: Xch1 Date: Tue, 30 Sep 2025 10:44:10 +0800 Subject: [PATCH 4/5] fix assets/test_gcs Signed-off-by: Xch1 --- providers/google/tests/unit/google/assets/test_gcs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/providers/google/tests/unit/google/assets/test_gcs.py b/providers/google/tests/unit/google/assets/test_gcs.py index e9920302b0e0a..9ee93d9f6e37f 100644 --- a/providers/google/tests/unit/google/assets/test_gcs.py +++ b/providers/google/tests/unit/google/assets/test_gcs.py @@ -33,7 +33,7 @@ def test_sanitize_uri(): def test_sanitize_uri_no_netloc(): - with pytest.raises(ValueError): + with pytest.raises(ValueError, match="URI format gs:// must contain"): sanitize_uri(urllib.parse.urlsplit("gs://")) From 2ab3c64b3b9b764f667c0656e2b8069b9c2f224d Mon Sep 17 00:00:00 2001 From: Xch1 Date: Tue, 30 Sep 2025 10:45:56 +0800 Subject: [PATCH 5/5] fix assets/test_bigquery Signed-off-by: Xch1 --- providers/google/tests/unit/google/assets/test_bigquery.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/providers/google/tests/unit/google/assets/test_bigquery.py b/providers/google/tests/unit/google/assets/test_bigquery.py index acc3adb9ef7cb..c2f4277944475 100644 --- a/providers/google/tests/unit/google/assets/test_bigquery.py +++ b/providers/google/tests/unit/google/assets/test_bigquery.py @@ -42,7 +42,7 @@ def test_sanitize_uri_pass() -> None: ) def test_sanitize_uri_fail(value: str) -> None: uri_i = urllib.parse.urlsplit(value) - with pytest.raises(ValueError): + with pytest.raises(ValueError, match="URI format bigquery:// must contain"): sanitize_uri(uri_i)