From b8b48ec7a4656987da155591ff69e2c61f6f480f Mon Sep 17 00:00:00 2001 From: Shahar Epstein <60007259+shahar1@users.noreply.github.com> Date: Wed, 1 Jul 2026 21:35:32 +0300 Subject: [PATCH] Trim redundant comments from KubernetesExecutor lazy-Manager tests The added tests carried a multi-line docstring and inline comments that restated what the test names and assertions already convey. Reducing them to the minimum keeps the intent while dropping the narration, following up on review feedback for #68800. --- .../kubernetes/executors/test_kubernetes_executor.py | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py b/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py index b3129c15ae920..285b263b064e1 100644 --- a/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py +++ b/providers/cncf/kubernetes/tests/unit/cncf/kubernetes/executors/test_kubernetes_executor.py @@ -2356,13 +2356,7 @@ def test_get_task_log(self, mock_get_kube_client, create_task_instance_of_operat ] def test_init_does_not_create_manager_process(self): - """ - Constructing the executor must not spawn a ``multiprocessing.Manager``. - - The API server builds a ``KubernetesExecutor`` purely to call ``get_task_log()`` for - RUNNING tasks and never starts it. Eagerly creating the Manager in ``__init__`` leaked an - orphaned ``serve_forever`` process per API-server worker. - """ + """Constructing the executor must not spawn a ``multiprocessing.Manager``.""" executor = KubernetesExecutor() assert executor._manager is None @@ -2391,7 +2385,6 @@ def test_end_without_start_is_noop(self): """``end()`` on an executor that was never started must not raise.""" executor = KubernetesExecutor() - # Must not raise even though no Manager/queues were ever created. executor.end() assert executor._manager is None @@ -2954,7 +2947,6 @@ def test_multiple_team_executors_isolation( team_b_executor.job_id = 2 try: - # Queues are created lazily in start(), so each team executor gets its own. team_a_executor.start() team_b_executor.start()