From 503fc45edb28e1f5ceaf1801ce0ee7130df6ddbc Mon Sep 17 00:00:00 2001 From: rjgoyln Date: Sun, 2 Aug 2026 13:43:52 +0800 Subject: [PATCH] Fix broken OpenAI batch trigger test blocking main Two PRs merged three hours apart on 2026-08-01 collided semantically: #69506 added a test using the class attribute END_TIME, and #69534 renamed that attribute to LEGACY_END_TIME while branched off a main that predated #69506. Git merged both cleanly, so the dangling reference reached main unnoticed and every job that collects the OpenAI provider tests now fails. The case asserts that a terminal batch emits exactly one event, which has nothing to do with the deprecated wall-clock deadline, so it moves to the timeout constant that the rest of the behavioural cases use rather than to LEGACY_END_TIME. The end_time path stays covered by test_serialization_with_legacy_end_time. --- providers/openai/tests/unit/openai/triggers/test_openai.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/providers/openai/tests/unit/openai/triggers/test_openai.py b/providers/openai/tests/unit/openai/triggers/test_openai.py index 9acc25d66c383..0a2c4322a5ed6 100644 --- a/providers/openai/tests/unit/openai/triggers/test_openai.py +++ b/providers/openai/tests/unit/openai/triggers/test_openai.py @@ -228,7 +228,7 @@ async def test_openai_batch_yields_single_terminal_event(self, mock_batch): conn_id=self.CONN_ID, batch_id=self.BATCH_ID, poll_interval=self.POLL_INTERVAL, - end_time=self.END_TIME, + timeout=self.TIMEOUT, ) events = [event async for event in trigger.run()] assert events == [