diff --git a/ambari-server/src/main/java/org/apache/ambari/server/api/resources/DetachedHostResourceDefinition.java b/ambari-server/src/main/java/org/apache/ambari/server/api/resources/DetachedHostResourceDefinition.java index 35e237cc78f..1d19ff190a7 100644 --- a/ambari-server/src/main/java/org/apache/ambari/server/api/resources/DetachedHostResourceDefinition.java +++ b/ambari-server/src/main/java/org/apache/ambari/server/api/resources/DetachedHostResourceDefinition.java @@ -21,6 +21,7 @@ import org.apache.ambari.server.api.query.render.HostSummaryRenderer; import org.apache.ambari.server.api.query.render.Renderer; +import org.apache.ambari.server.controller.internal.HostResourceProvider; import org.apache.ambari.server.controller.spi.Resource; @@ -45,7 +46,7 @@ public String getSingularName() { @Override public Renderer getRenderer(String name) { - if (name.equals("summary")) { + if (HostResourceProvider.SUMMARY_PROPERTY_ID.equals(name)) { return new HostSummaryRenderer(); } return super.getRenderer(name); diff --git a/ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java b/ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java index 46ca04add1c..d8c92afde3e 100644 --- a/ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java +++ b/ambari-server/src/main/java/org/apache/ambari/server/api/resources/HostResourceDefinition.java @@ -26,6 +26,7 @@ import org.apache.ambari.server.api.query.render.HostSummaryRenderer; import org.apache.ambari.server.api.query.render.Renderer; +import org.apache.ambari.server.controller.internal.HostResourceProvider; import org.apache.ambari.server.controller.spi.Request; import org.apache.ambari.server.controller.spi.Resource; @@ -58,7 +59,7 @@ public Collection getDeleteDirectives() { @Override public Renderer getRenderer(String name) { - if (name.equals("summary")) { + if (HostResourceProvider.SUMMARY_PROPERTY_ID.equals(name)) { return new HostSummaryRenderer(); } return super.getRenderer(name); diff --git a/ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java b/ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java index c028749a2be..f6dbd58d48d 100644 --- a/ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java +++ b/ambari-server/src/test/java/org/apache/ambari/server/api/resources/HostResourceDefinitionTest.java @@ -19,10 +19,13 @@ package org.apache.ambari.server.api.resources; import static org.junit.Assert.assertEquals; +import static org.junit.Assert.assertSame; import static org.junit.Assert.assertTrue; import java.util.Set; +import org.apache.ambari.server.api.query.render.DefaultRenderer; +import org.apache.ambari.server.api.query.render.HostSummaryRenderer; import org.apache.ambari.server.controller.spi.Resource; import org.junit.Test; @@ -53,6 +56,13 @@ public void testGetSubResourceDefinitions() { assertTrue(includesType(subResources, Resource.Type.HostKerberosIdentity)); } + @Test + public void getRenderer() { + ResourceDefinition resource = new HostResourceDefinition(); + assertSame(HostSummaryRenderer.class, resource.getRenderer("summary").getClass()); + assertSame(DefaultRenderer.class, resource.getRenderer(null).getClass()); + } + private boolean includesType(Set resources, Resource.Type type) { for (SubResourceDefinition subResource : resources) { if (subResource.getType() == type) {