Skip to content

Commit 53c5af0

Browse files
committed
ARROW-6478: [C++] Revert to jemalloc stable-4 until we understand 5.2.x performance issues
I propose we revert to the jemalloc 4.x stable branch where we were before until we understand how to get the performance we need for our workloads from 5.x. See upstream issue jemalloc/jemalloc#1621 Closes #5297 from wesm/ARROW-6417-jemalloc and squashes the following commits: eee3fbc <Wes McKinney> Add jemalloc pinned version to versions.txt a68f1a3 <Wes McKinney> Revert to jemalloc stable-4 Authored-by: Wes McKinney <wesm+git@apache.org> Signed-off-by: Wes McKinney <wesm+git@apache.org>
1 parent b8ebc9d commit 53c5af0

File tree

3 files changed

+5
-9
lines changed

3 files changed

+5
-9
lines changed

cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1376,19 +1376,16 @@ if(ARROW_JEMALLOC)
13761376
"${JEMALLOC_PREFIX}/lib/libjemalloc_pic${CMAKE_STATIC_LIBRARY_SUFFIX}")
13771377
externalproject_add(
13781378
jemalloc_ep
1379-
URL ${JEMALLOC_SOURCE_URL}
1379+
URL ${CMAKE_CURRENT_SOURCE_DIR}/thirdparty/jemalloc/${JEMALLOC_VERSION}.tar.gz
13801380
PATCH_COMMAND touch doc/jemalloc.3 doc/jemalloc.html
1381-
CONFIGURE_COMMAND ./configure
1381+
CONFIGURE_COMMAND ./autogen.sh
13821382
"AR=${CMAKE_AR}"
13831383
"CC=${CMAKE_C_COMPILER}"
13841384
"--prefix=${JEMALLOC_PREFIX}"
13851385
"--with-jemalloc-prefix=je_arrow_"
13861386
"--with-private-namespace=je_arrow_private_"
1387-
"--without-export"
1388-
# Don't override operator new()
1389-
"--disable-cxx" "--disable-libdl"
1390-
# See https://github.com/jemalloc/jemalloc/issues/1237
1391-
"--disable-initial-exec-tls" ${EP_LOG_OPTIONS}
1387+
"--disable-tls"
1388+
${EP_LOG_OPTIONS}
13921389
BUILD_IN_SOURCE 1
13931390
BUILD_COMMAND ${MAKE} ${MAKE_BUILD_ARGS}
13941391
BUILD_BYPRODUCTS "${JEMALLOC_STATIC_LIB}"
Binary file not shown.

cpp/thirdparty/versions.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ GFLAGS_VERSION=v2.2.0
3535
GLOG_VERSION=v0.3.5
3636
GRPC_VERSION=v1.20.0
3737
GTEST_VERSION=1.8.1
38-
JEMALLOC_VERSION=5.2.0
38+
JEMALLOC_VERSION=17c897976c60b0e6e4f4a365c751027244dada7a
3939
LZ4_VERSION=v1.8.3
4040
ORC_VERSION=1.5.5
4141
PROTOBUF_VERSION=v3.7.1
@@ -68,7 +68,6 @@ DEPENDENCIES=(
6868
"ARROW_GLOG_URL glog-${GLOG_VERSION}.tar.gz https://github.com/google/glog/archive/${GLOG_VERSION}.tar.gz"
6969
"ARROW_GRPC_URL grpc-${GRPC_VERSION}.tar.gz https://github.com/grpc/grpc/archive/${GRPC_VERSION}.tar.gz"
7070
"ARROW_GTEST_URL gtest-${GTEST_VERSION}.tar.gz https://github.com/google/googletest/archive/release-${GTEST_VERSION}.tar.gz"
71-
"ARROW_JEMALLOC_URL jemalloc-${JEMALLOC_VERSION}.tar.bz2 https://github.com/jemalloc/jemalloc/releases/download/${JEMALLOC_VERSION}/jemalloc-${JEMALLOC_VERSION}.tar.bz2"
7271
"ARROW_LZ4_URL lz4-${LZ4_VERSION}.tar.gz https://github.com/lz4/lz4/archive/${LZ4_VERSION}.tar.gz"
7372
"ARROW_ORC_URL orc-${ORC_VERSION}.tar.gz https://github.com/apache/orc/archive/rel/release-${ORC_VERSION}.tar.gz"
7473
"ARROW_PROTOBUF_URL protobuf-${PROTOBUF_VERSION}.tar.gz https://github.com/google/protobuf/releases/download/${PROTOBUF_VERSION}/protobuf-all-${PROTOBUF_VERSION:1}.tar.gz"

0 commit comments

Comments
 (0)