Add string reverse functions and stringi to suggests

Author: thisisnic

r/DESCRIPTION

@@ -48,6 +48,7 @@ Suggests:
     pkgload,
     reticulate,
     rmarkdown,
+    stringi,
     stringr,
     testthat,
     tibble,

r/R/expression.R

@@ -29,7 +29,8 @@
   # stringr spellings of those
   "str_length" = "utf8_length",
   "str_to_lower" = "utf8_lower",
-  "str_to_upper" = "utf8_upper"
+  "str_to_upper" = "utf8_upper",
+  "str_reverse" = "utf8_reverse"
   # str_trim is defined in dplyr.R
 )
 

r/tests/testthat/test-dplyr-string-functions.R

@@ -20,6 +20,7 @@ skip_if_not_available("utf8proc")
 
 library(dplyr)
 library(stringr)
+library(stringi)
 
 test_that("paste, paste0, and str_c", {
   df <- tibble(
@@ -725,26 +726,24 @@ test_that("errors in strptime", {
   )
 })
 
-test_that("arrow_utf8_reverse and arrow_ascii_reverse functions", {
+test_that("stri_reverse and arrow_ascii_reverse functions", {
 
   df_ascii <- tibble(x = c("Foo\nand bar", "baz\tand qux and quux"))
 
   df_utf8 <- tibble(x = c("Foo\u00A0\u0061nd\u00A0bar", "\u0062az\u00A0and\u00A0qux\u3000and\u00A0quux"))
 
-  expect_equivalent(
-    df_ascii %>%
-      Table$create() %>%
-      mutate(x = arrow_utf8_reverse(x)) %>%
+  expect_dplyr_equal(
+    input %>%
+      mutate(x = stri_reverse(x)) %>%
       collect(),
-    tibble(x = c("rab dna\nooF", "xuuq dna xuq dna\tzab"))
+    df_utf8
   )
 
-  expect_equivalent(
-    df_utf8 %>%
-      Table$create() %>%
-      mutate(x = arrow_utf8_reverse(x)) %>%
+  expect_dplyr_equal(
+    input %>%
+      mutate(x = stri_reverse(x)) %>%
       collect(),
-    tibble(x = c("rab\u00A0dn\u0061\u00A0ooF", "xuuq\u00A0dna\u3000xuq\u00A0dna\u00A0za\u0062"))
+    df_ascii
   )
 
   expect_equivalent(