From ed0f944bff726b8b89eaa004624ec90e8e10a0c9 Mon Sep 17 00:00:00 2001 From: Sutou Kouhei Date: Tue, 4 Jul 2023 21:44:22 +0900 Subject: [PATCH 1/2] GH-36449: [C++][CI] Don't use -g1 for Python jobs Python jobs have tests for GDB plugin. We can't use -g1 for GDB plugin because -g1 doesn't provide enough debug information. --- ci/docker/linux-apt-python-3.dockerfile | 1 + ci/docker/linux-dnf-python-3.dockerfile | 1 + 2 files changed, 2 insertions(+) diff --git a/ci/docker/linux-apt-python-3.dockerfile b/ci/docker/linux-apt-python-3.dockerfile index d4e4dec36ab0..829c32e96b1a 100644 --- a/ci/docker/linux-apt-python-3.dockerfile +++ b/ci/docker/linux-apt-python-3.dockerfile @@ -53,6 +53,7 @@ ENV ARROW_ACERO=ON \ ARROW_CSV=ON \ ARROW_DATASET=ON \ ARROW_FILESYSTEM=ON \ + ARROW_GDB=ON \ ARROW_HDFS=ON \ ARROW_JSON=ON \ ARROW_USE_GLOG=OFF diff --git a/ci/docker/linux-dnf-python-3.dockerfile b/ci/docker/linux-dnf-python-3.dockerfile index d1035255d3a9..98f9f64885db 100644 --- a/ci/docker/linux-dnf-python-3.dockerfile +++ b/ci/docker/linux-dnf-python-3.dockerfile @@ -44,6 +44,7 @@ ENV ARROW_ACERO=ON \ ARROW_CSV=ON \ ARROW_DATASET=ON \ ARROW_FILESYSTEM=ON \ + ARROW_GDB=ON \ ARROW_HDFS=ON \ ARROW_JSON=ON \ ARROW_USE_GLOG=OFF From 3c2f5e9355cebee68ef0df08e59241995993af88 Mon Sep 17 00:00:00 2001 From: Antoine Pitrou Date: Tue, 4 Jul 2023 14:56:31 +0200 Subject: [PATCH 2/2] Fix Numpy warnings --- python/pyarrow/tests/test_cuda.py | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/python/pyarrow/tests/test_cuda.py b/python/pyarrow/tests/test_cuda.py index 2ba2f826737b..43cd16a3cf66 100644 --- a/python/pyarrow/tests/test_cuda.py +++ b/python/pyarrow/tests/test_cuda.py @@ -349,27 +349,29 @@ def test_HostBuffer(size): @pytest.mark.parametrize("size", [0, 1, 1000]) def test_copy_from_to_host(size): - # Create a buffer in host containing range(size) - buf = pa.allocate_buffer(size, resizable=True) # in host + dt = np.dtype('uint16') + nbytes = size * dt.itemsize + buf = pa.allocate_buffer(nbytes, resizable=True) # in host assert isinstance(buf, pa.Buffer) assert not isinstance(buf, cuda.CudaBuffer) - arr = np.frombuffer(buf, dtype=np.uint8) + arr = np.frombuffer(buf, dtype=dt) assert arr.size == size arr[:] = range(size) - arr_ = np.frombuffer(buf, dtype=np.uint8) + arr_ = np.frombuffer(buf, dtype=dt) np.testing.assert_equal(arr, arr_) - device_buffer = global_context.new_buffer(size) + # Create a device buffer of the same size and copy from host + device_buffer = global_context.new_buffer(nbytes) assert isinstance(device_buffer, cuda.CudaBuffer) assert isinstance(device_buffer, pa.Buffer) - assert device_buffer.size == size + assert device_buffer.size == nbytes assert not device_buffer.is_cpu + device_buffer.copy_from_host(buf, position=0, nbytes=nbytes) - device_buffer.copy_from_host(buf, position=0, nbytes=size) - - buf2 = device_buffer.copy_to_host(position=0, nbytes=size) - arr2 = np.frombuffer(buf2, dtype=np.uint8) + # Copy back to host and compare contents + buf2 = device_buffer.copy_to_host(position=0, nbytes=nbytes) + arr2 = np.frombuffer(buf2, dtype=dt) np.testing.assert_equal(arr, arr2)