From c7fea2a531244a716cfb274f1dd1e49d7edb5875 Mon Sep 17 00:00:00 2001 From: Wes McKinney Date: Fri, 27 Mar 2020 14:02:36 -0500 Subject: [PATCH 1/2] Add -Wa,-mbig-obj on MinGW if it is supported --- cpp/cmake_modules/SetupCxxFlags.cmake | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/cpp/cmake_modules/SetupCxxFlags.cmake b/cpp/cmake_modules/SetupCxxFlags.cmake index 441b43ed72a6..8aee0cedde21 100644 --- a/cpp/cmake_modules/SetupCxxFlags.cmake +++ b/cpp/cmake_modules/SetupCxxFlags.cmake @@ -97,6 +97,12 @@ if(WIN32) # Support large object code set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} /bigobj") + else() + # MinGW + check_cxx_compiler_flag(-Wa,-mbig-obj MINGW_SUPPORTS_BIG_OBJ) + if(MINGW_SUPPORTS_BIG_OBJ) + set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wa,-mbig-obj") + endif() endif(MSVC) else() # Common flags set below with warning level From 1b01fd1e05a7430f77ffc97dbd3b531888f0a178 Mon Sep 17 00:00:00 2001 From: Wes McKinney Date: Fri, 27 Mar 2020 14:04:29 -0500 Subject: [PATCH 2/2] s/MINGW/CXX --- cpp/cmake_modules/SetupCxxFlags.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpp/cmake_modules/SetupCxxFlags.cmake b/cpp/cmake_modules/SetupCxxFlags.cmake index 8aee0cedde21..046311d9c7ef 100644 --- a/cpp/cmake_modules/SetupCxxFlags.cmake +++ b/cpp/cmake_modules/SetupCxxFlags.cmake @@ -99,8 +99,8 @@ if(WIN32) set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} /bigobj") else() # MinGW - check_cxx_compiler_flag(-Wa,-mbig-obj MINGW_SUPPORTS_BIG_OBJ) - if(MINGW_SUPPORTS_BIG_OBJ) + check_cxx_compiler_flag(-Wa,-mbig-obj CXX_SUPPORTS_BIG_OBJ) + if(CXX_SUPPORTS_BIG_OBJ) set(CXX_COMMON_FLAGS "${CXX_COMMON_FLAGS} -Wa,-mbig-obj") endif() endif(MSVC)