fix: skip close on bundles (#32661) (#32759)

mutianf · web-flow · commit 83a883d6cf6b · 2024-10-13T22:54:51.000-04:00
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableIO.java
@@ -2021,10 +2021,9 @@ public void close() throws IOException {
         reader.close();
         reader = null;
       }
-      if (serviceEntry != null) {
-        serviceEntry.close();
-        serviceEntry = null;
-      }
+      // Skipping closing the service entry on each bundle.
+      // In the future we'll close the Bigtable client in
+      // teardown.
     }
 
     @Override

Original file line number	Diff line number	Diff line change
`@@ -2021,10 +2021,9 @@ public void close() throws IOException {`
`2021`	`2021`	`reader.close();`
`2022`	`2022`	`reader = null;`
`2023`	`2023`	`}`
`2024`		`- if (serviceEntry != null) {`
`2025`		`- serviceEntry.close();`
`2026`		`- serviceEntry = null;`
`2027`		`- }`
	`2024`	`+ // Skipping closing the service entry on each bundle.`
	`2025`	`+ // In the future we'll close the Bigtable client in`
	`2026`	`+ // teardown.`
`2028`	`2027`	`}`
`2029`	`2028`
`2030`	`2029`	`@Override`