Skip to content

Commit a0674a9

Browse files
authored
[ErrorProne] Fix InvalidParam, InvalidInlineTag, InvalidBlockTag, and InvalidLink checks (#37773)
* Fix InvalidInlineTag, InvalidParam, InvalidBlockTag and InvalidLink javadocs * Fix JdbcUtil after merge * spotless * changes * leave ignore block * Fix InvalidLink and restore InvalidBlockTag to disabledChecks * Remove duplicate entry
1 parent cf536ea commit a0674a9

File tree

70 files changed

+126
-137
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

70 files changed

+126
-137
lines changed

buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1545,9 +1545,6 @@ class BeamModulePlugin implements Plugin<Project> {
15451545
"ExtendsAutoValue",
15461546
"InlineMeSuggester",
15471547
"InvalidBlockTag",
1548-
"InvalidInlineTag",
1549-
"InvalidLink",
1550-
"InvalidParam",
15511548
"InvalidThrows",
15521549
"JavaTimeDefaultTimeZone",
15531550
"JavaUtilDate",

examples/java/webapis/src/main/java/org/apache/beam/examples/webapis/ImageRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ static Builder builder() {
5454
return new AutoValue_ImageRequest.Builder();
5555
}
5656

57-
/** Build an {@link ImageRequest} from a {@param url}. */
57+
/** Build an {@link ImageRequest} from a {@code url}. */
5858
static ImageRequest of(String url) {
5959
return builder().setImageUrl(url).setMimeType(mimeTypeOf(url)).build();
6060
}

it/google-cloud-platform/src/main/java/org/apache/beam/it/gcp/LoadTestBase.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -211,7 +211,7 @@ protected boolean waitForNumMessages(String jobId, String pcollection, Long expe
211211
*
212212
* @param metrics a map of raw metrics. The results are also appened in the map.
213213
* @param launchInfo Job info of the job
214-
* @param config a {@class MetricsConfiguration}
214+
* @param config a {@link MetricsConfiguration}
215215
*/
216216
private void computeDataflowMetrics(
217217
Map<String, Double> metrics, LaunchInfo launchInfo, MetricsConfiguration config)
@@ -365,7 +365,7 @@ protected Map<String, Double> getCpuUtilizationMetrics(String jobId, TimeInterva
365365
* Computes throughput metrics of the given pcollection in dataflow job.
366366
*
367367
* @param jobInfo dataflow job LaunchInfo
368-
* @param config the {@class MetricsConfiguration}
368+
* @param config the {@link MetricsConfiguration}
369369
* @param timeInterval interval for the monitoring query
370370
* @return throughput metrics of the pcollection
371371
*/

it/google-cloud-platform/src/test/java/org/apache/beam/it/gcp/storage/FileBasedIOLT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ static class Configuration extends SyntheticSourceOptions {
251251
/** Number of dynamic destinations to write. */
252252
@JsonProperty public int numShards = 0;
253253

254-
/** See {@class org.apache.beam.sdk.io.Compression}. */
254+
/** See {@link org.apache.beam.sdk.io.Compression}. */
255255
@JsonProperty public String compressionType = "UNCOMPRESSED";
256256

257257
/** Runner specified to run the pipeline. */

runners/core-java/src/main/java/org/apache/beam/runners/core/StatefulDoFnRunner.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,7 @@
4949
/**
5050
* A customized {@link DoFnRunner} that handles late data dropping and garbage collection for
5151
* stateful {@link DoFn DoFns}. It registers a GC timer in {@link #processElement(WindowedValue)}
52-
* and does cleanup in {@link #onTimer(String, String, BoundedWindow, Instant, Instant, TimeDomain,
53-
* boolean)}
52+
* and does cleanup in {@link #onTimer}
5453
*
5554
* @param <InputT> the type of the {@link DoFn} (main) input elements
5655
* @param <OutputT> the type of the {@link DoFn} (main) output elements

runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectTimerInternals.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,14 +95,14 @@ public void deleteTimer(
9595
timeDomain));
9696
}
9797

98-
/** @deprecated use {@link #deleteTimer(StateNamespace, String, TimeDomain)}. */
98+
/** @deprecated use {@link #deleteTimer(StateNamespace, String, String, TimeDomain)}. */
9999
@Deprecated
100100
@Override
101101
public void deleteTimer(StateNamespace namespace, String timerId, String timerFamilyId) {
102102
throw new UnsupportedOperationException("Canceling of timer by ID is not yet supported.");
103103
}
104104

105-
/** @deprecated use {@link #deleteTimer(StateNamespace, String, TimeDomain)}. */
105+
/** @deprecated use {@link #deleteTimer(StateNamespace, String, String, TimeDomain)}. */
106106
@Deprecated
107107
@Override
108108
public void deleteTimer(TimerData timerData) {

runners/flink/1.19/src/test/java/org/apache/beam/runners/flink/streaming/StreamSources.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public interface OutputWrapper<T> extends Output<T> {
5252
@Override
5353
default void emitWatermarkStatus(WatermarkStatus watermarkStatus) {}
5454

55-
/** In Flink 1.19 the {@code emitRecordAttributes} method was added. */
55+
/** In Flink 1.19 the {@code recordAttributes} method was added. */
5656
@Override
5757
default void emitRecordAttributes(RecordAttributes recordAttributes) {
5858
throw new UnsupportedOperationException("emitRecordAttributes not implemented");

runners/flink/1.20/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1655,7 +1655,7 @@ void onFiredOrDeletedTimer(TimerData timer) {
16551655
}
16561656
}
16571657

1658-
/** @deprecated use {@link #deleteTimer(StateNamespace, String, TimeDomain)}. */
1658+
/** @deprecated use {@link #deleteTimer(StateNamespace, String, String, TimeDomain)}. */
16591659
@Deprecated
16601660
@Override
16611661
public void deleteTimer(StateNamespace namespace, String timerId, String timerFamilyId) {
@@ -1672,7 +1672,7 @@ public void deleteTimer(
16721672
}
16731673
}
16741674

1675-
/** @deprecated use {@link #deleteTimer(StateNamespace, String, TimeDomain)}. */
1675+
/** @deprecated use {@link #deleteTimer(StateNamespace, String, String, TimeDomain)}. */
16761676
@Override
16771677
@Deprecated
16781678
public void deleteTimer(TimerData timer) {

runners/flink/2.0/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/DoFnOperator.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1655,7 +1655,7 @@ void onFiredOrDeletedTimer(TimerData timer) {
16551655
}
16561656
}
16571657

1658-
/** @deprecated use {@link #deleteTimer(StateNamespace, String, TimeDomain)}. */
1658+
/** @deprecated use {@link #deleteTimer(StateNamespace, String, String, TimeDomain)}. */
16591659
@Deprecated
16601660
@Override
16611661
public void deleteTimer(StateNamespace namespace, String timerId, String timerFamilyId) {
@@ -1672,7 +1672,7 @@ public void deleteTimer(
16721672
}
16731673
}
16741674

1675-
/** @deprecated use {@link #deleteTimer(StateNamespace, String, TimeDomain)}. */
1675+
/** @deprecated use {@link #deleteTimer(StateNamespace, String, String, TimeDomain)}. */
16761676
@Override
16771677
@Deprecated
16781678
public void deleteTimer(TimerData timer) {

runners/flink/2.0/src/test/java/org/apache/beam/runners/flink/streaming/StreamSources.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public interface OutputWrapper<T> extends Output<T> {
5252
@Override
5353
default void emitWatermarkStatus(WatermarkStatus watermarkStatus) {}
5454

55-
/** In Flink 1.19 the {@code emitRecordAttributes} method was added. */
55+
/** In Flink 1.19 the {@code recordAttributes} method was added. */
5656
@Override
5757
default void emitRecordAttributes(RecordAttributes recordAttributes) {
5858
throw new UnsupportedOperationException("emitRecordAttributes not implemented");

0 commit comments

Comments
 (0)