From 3c85daab6c390ba0372a364cdcdddeb411d7e220 Mon Sep 17 00:00:00 2001 From: shustsud Date: Fri, 29 Oct 2021 09:28:48 +0900 Subject: [PATCH 1/2] Add log --- .../bookkeeper/bookie/ScanAndCompareGarbageCollector.java | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java index faac25949ec..caec05248f5 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java @@ -240,6 +240,10 @@ private Set removeOverReplicatedledgers(Set bkActiveledgers, final G continue; } } catch (Throwable t) { + if (!(t.getCause() instanceof BKException.BKNoSuchLedgerExistsOnMetadataServerException)) { + LOG.warn("Failed to get metadata for ledger {}. {}: {}", + ledgerId, t.getClass().getName(), t.getMessage()); + } latch.countDown(); continue; } @@ -265,6 +269,10 @@ private Set removeOverReplicatedledgers(Set bkActiveledgers, final G overReplicatedLedgers.add(ledgerId); garbageCleaner.clean(ledgerId); } + } else if (!(exception instanceof + BKException.BKNoSuchLedgerExistsOnMetadataServerException)) { + LOG.warn("Failed to get metadata for ledger {}. {}: {}", + ledgerId, exception.getClass().getName(), exception.getMessage()); } } finally { semaphore.release(); From b3da3dcd31180ae288b64fb7868b98f997e62106 Mon Sep 17 00:00:00 2001 From: shustsud Date: Mon, 1 Nov 2021 08:20:34 +0900 Subject: [PATCH 2/2] Fixed checkstyle --- .../bookkeeper/bookie/ScanAndCompareGarbageCollector.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java index caec05248f5..d8207697faf 100644 --- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java +++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/ScanAndCompareGarbageCollector.java @@ -269,8 +269,8 @@ private Set removeOverReplicatedledgers(Set bkActiveledgers, final G overReplicatedLedgers.add(ledgerId); garbageCleaner.clean(ledgerId); } - } else if (!(exception instanceof - BKException.BKNoSuchLedgerExistsOnMetadataServerException)) { + } else if (!(exception + instanceof BKException.BKNoSuchLedgerExistsOnMetadataServerException)) { LOG.warn("Failed to get metadata for ledger {}. {}: {}", ledgerId, exception.getClass().getName(), exception.getMessage()); }