From 7c6ef5bef766769f5093fe29b18612a3a9cda4d9 Mon Sep 17 00:00:00 2001 From: Maurice Barnum Date: Mon, 7 Feb 2022 19:02:06 -0800 Subject: [PATCH] fix gradle implicit dependency ``` > Task :bookkeeper-tools-framework:compileTestJava Execution optimizations have been disabled for task ':bookkeeper-tools-framework:compileTestJava' to ensure correctness due to the following reasons: - Gradle detected a problem with the following location: '/Users/mbarnum/src/bookkeeper/tools/framework/build/classes/java/main'. Reason: Task ':bookkeeper-tools-framework:compileTestJava' uses this output of task ':tools:framework:compileJava' without declaring an explicit or implicit dependency. This can lead to incorrect results being produced, depending on what order the tasks are executed. Please refer to https://docs.gradle.org/7.3.3/userguide/validation_problems.html#implicit_dependency for more details about this problem. ``` --- bookkeeper-server/build.gradle | 2 +- settings.gradle | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/bookkeeper-server/build.gradle b/bookkeeper-server/build.gradle index d55aa8a9c2a..53187915aba 100644 --- a/bookkeeper-server/build.gradle +++ b/bookkeeper-server/build.gradle @@ -28,9 +28,9 @@ dependencies { implementation project(':bookkeeper-http:http-server') implementation project(':bookkeeper-proto') implementation project(':bookkeeper-stats') + implementation project(':bookkeeper-tools-framework') implementation project(':circe-checksum') implementation project(':cpu-affinity') - implementation project(':tools:framework') compileOnly depLibs.lombok compileOnly depLibs.spotbugsAnnotations diff --git a/settings.gradle b/settings.gradle index 036b10413e0..4950bce657b 100644 --- a/settings.gradle +++ b/settings.gradle @@ -101,8 +101,7 @@ include(':bookkeeper-benchmark', 'tests:scripts', 'tests:shaded:bookkeeper-server-shaded-test', 'tests:shaded:bookkeeper-server-tests-shaded-test', - 'tests:shaded:distributedlog-core-shaded-test', - 'tools:framework') + 'tests:shaded:distributedlog-core-shaded-test') project(':bookkeeper-tools').projectDir = file('tools/all') project(':bookkeeper-tools-framework').projectDir = file('tools/framework')