From 7e8af0f60386a97c2e26c3f37575eec8403be0f4 Mon Sep 17 00:00:00 2001 From: Matteo Merli Date: Thu, 2 Mar 2023 14:29:45 -0800 Subject: [PATCH 1/2] Fixed CI PR validation --- .github/workflows/bk-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/bk-ci.yml b/.github/workflows/bk-ci.yml index c38a2680ac1..8b15fd3f10d 100644 --- a/.github/workflows/bk-ci.yml +++ b/.github/workflows/bk-ci.yml @@ -89,7 +89,7 @@ jobs: - name: Generate Javadoc if: steps.check_changes.outputs.docs_only != 'true' - run: mvn -B -nsu -am -pl bookkeeper-common,bookkeeper-server,:bookkeeper-stats-api,:bookkeeper-stats-providers,:codahale-metrics-provider,:prometheus-metrics-provider javadoc:aggregate -DskipTests -Pdelombok -Dchesktyle.skip -Dspotbugs.skip + run: mvn -B -nsu -am -pl testtools,bookkeeper-common,bookkeeper-server,:bookkeeper-stats-api,:bookkeeper-stats-providers,:codahale-metrics-provider,:prometheus-metrics-provider javadoc:aggregate -DskipTests -Pdelombok -Dchesktyle.skip -Dspotbugs.skip unit-tests: name: ${{ matrix.step_name }} From ecd312aea7d470123fca32794b196871e3b06247 Mon Sep 17 00:00:00 2001 From: Matteo Merli Date: Thu, 2 Mar 2023 14:58:26 -0800 Subject: [PATCH 2/2] Install module before --- .github/workflows/bk-ci.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/bk-ci.yml b/.github/workflows/bk-ci.yml index 8b15fd3f10d..d989ba7bc94 100644 --- a/.github/workflows/bk-ci.yml +++ b/.github/workflows/bk-ci.yml @@ -81,7 +81,9 @@ jobs: - name: Validate pull request if: steps.check_changes.outputs.docs_only != 'true' - run: mvn clean -T 1C -B -nsu apache-rat:check checkstyle:check spotbugs:check package -Ddistributedlog -DskipTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO + run: | + mvn -T 1C -B -nsu clean install -Ddistributedlog -DskipTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO + mvn -T 1C -B -nsu apache-rat:check checkstyle:check spotbugs:check package -Ddistributedlog -DskipTests -Dorg.slf4j.simpleLogger.defaultLogLevel=INFO - name: Check license files if: steps.check_changes.outputs.docs_only != 'true' @@ -89,7 +91,7 @@ jobs: - name: Generate Javadoc if: steps.check_changes.outputs.docs_only != 'true' - run: mvn -B -nsu -am -pl testtools,bookkeeper-common,bookkeeper-server,:bookkeeper-stats-api,:bookkeeper-stats-providers,:codahale-metrics-provider,:prometheus-metrics-provider javadoc:aggregate -DskipTests -Pdelombok -Dchesktyle.skip -Dspotbugs.skip + run: mvn -B -nsu -am -pl bookkeeper-common,bookkeeper-server,:bookkeeper-stats-api,:bookkeeper-stats-providers,:codahale-metrics-provider,:prometheus-metrics-provider javadoc:aggregate -DskipTests -Pdelombok -Dchesktyle.skip -Dspotbugs.skip unit-tests: name: ${{ matrix.step_name }}