From d898ccb50361fee6433cddcefe685ad27624915b Mon Sep 17 00:00:00 2001 From: chenguangming Date: Tue, 26 Jul 2022 17:32:37 +0800 Subject: [PATCH] call AfterHCCompleted when WaitAndReset fails --- src/brpc/details/health_check.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/brpc/details/health_check.cpp b/src/brpc/details/health_check.cpp index 2800e6927f..ab838cc8b2 100644 --- a/src/brpc/details/health_check.cpp +++ b/src/brpc/details/health_check.cpp @@ -167,7 +167,7 @@ bool HealthCheckTask::OnTriggeringTask(timespec* next_abstime) { << " was abandoned before health checking"; return false; } - // Note: Making a Socket re-addessable is hard. An alternative is + // Note: Making a Socket re-addressable is hard. An alternative is // creating another Socket with selected internal fields to replace // failed Socket. Although it avoids concurrent issues with in-place // revive, it changes SocketId: many code need to watch SocketId @@ -189,6 +189,7 @@ bool HealthCheckTask::OnTriggeringTask(timespec* next_abstime) { _first_time = false; if (ptr->WaitAndReset(2/*note*/) != 0) { LOG(INFO) << "Cancel checking " << *ptr; + ptr->AfterHCCompleted(); return false; } }