From 0c1cb19c424d252d565dd75cd26859df5a0f3cd2 Mon Sep 17 00:00:00 2001 From: Bright Chen Date: Mon, 31 Mar 2025 22:34:43 +0800 Subject: [PATCH] Remove Incorrect log in RemoveServersInBatch --- src/brpc/policy/consistent_hashing_load_balancer.cpp | 3 --- src/brpc/policy/dynpart_load_balancer.cpp | 3 --- src/brpc/policy/randomized_load_balancer.cpp | 3 --- src/brpc/policy/round_robin_load_balancer.cpp | 3 --- src/brpc/policy/weighted_round_robin_load_balancer.cpp | 3 --- 5 files changed, 15 deletions(-) diff --git a/src/brpc/policy/consistent_hashing_load_balancer.cpp b/src/brpc/policy/consistent_hashing_load_balancer.cpp index c18c9a34c0..2560d8f29b 100644 --- a/src/brpc/policy/consistent_hashing_load_balancer.cpp +++ b/src/brpc/policy/consistent_hashing_load_balancer.cpp @@ -267,9 +267,6 @@ size_t ConsistentHashingLoadBalancer::RemoveServersInBatch( const size_t ret = _db_hash_ring.ModifyWithForeground(RemoveBatch, servers, &executed); CHECK(ret % _num_replicas == 0); const size_t n = ret / _num_replicas; - LOG_IF(ERROR, n != servers.size()) - << "Fail to RemoveServersInBatch, expected " << servers.size() - << " actually " << n; return n; } diff --git a/src/brpc/policy/dynpart_load_balancer.cpp b/src/brpc/policy/dynpart_load_balancer.cpp index 579ca7dd52..ad3cbbcbff 100644 --- a/src/brpc/policy/dynpart_load_balancer.cpp +++ b/src/brpc/policy/dynpart_load_balancer.cpp @@ -95,9 +95,6 @@ size_t DynPartLoadBalancer::AddServersInBatch( size_t DynPartLoadBalancer::RemoveServersInBatch( const std::vector& servers) { const size_t n = _db_servers.Modify(BatchRemove, servers); - LOG_IF(ERROR, n != servers.size()) - << "Fail to RemoveServersInBatch, expected " << servers.size() - << " actually " << n; return n; } diff --git a/src/brpc/policy/randomized_load_balancer.cpp b/src/brpc/policy/randomized_load_balancer.cpp index cac695af1e..353074ebfa 100644 --- a/src/brpc/policy/randomized_load_balancer.cpp +++ b/src/brpc/policy/randomized_load_balancer.cpp @@ -97,9 +97,6 @@ size_t RandomizedLoadBalancer::AddServersInBatch( size_t RandomizedLoadBalancer::RemoveServersInBatch( const std::vector& servers) { const size_t n = _db_servers.Modify(BatchRemove, servers); - LOG_IF(ERROR, n != servers.size()) - << "Fail to RemoveServersInBatch, expected " << servers.size() - << " actually " << n; return n; } diff --git a/src/brpc/policy/round_robin_load_balancer.cpp b/src/brpc/policy/round_robin_load_balancer.cpp index c7dd972d20..0bc2f58b68 100644 --- a/src/brpc/policy/round_robin_load_balancer.cpp +++ b/src/brpc/policy/round_robin_load_balancer.cpp @@ -97,9 +97,6 @@ size_t RoundRobinLoadBalancer::AddServersInBatch( size_t RoundRobinLoadBalancer::RemoveServersInBatch( const std::vector& servers) { const size_t n = _db_servers.Modify(BatchRemove, servers); - LOG_IF(ERROR, n != servers.size()) - << "Fail to RemoveServersInBatch, expected " << servers.size() - << " actually " << n; return n; } diff --git a/src/brpc/policy/weighted_round_robin_load_balancer.cpp b/src/brpc/policy/weighted_round_robin_load_balancer.cpp index 2a98e7fbe8..598d7dc069 100644 --- a/src/brpc/policy/weighted_round_robin_load_balancer.cpp +++ b/src/brpc/policy/weighted_round_robin_load_balancer.cpp @@ -150,9 +150,6 @@ size_t WeightedRoundRobinLoadBalancer::AddServersInBatch( size_t WeightedRoundRobinLoadBalancer::RemoveServersInBatch( const std::vector& servers) { const size_t n = _db_servers.Modify(BatchRemove, servers); - LOG_IF(ERROR, n != servers.size()) - << "Fail to RemoveServersInBatch, expected " << servers.size() - << " actually " << n; return n; }