Skip to content

Remove deprecated usage of Exchange.getOut in StaxProcessor#11752

Closed
apupier wants to merge 1 commit into
apache:mainfrom
apupier:removeDeprecateGetOutInCamelStax
Closed

Remove deprecated usage of Exchange.getOut in StaxProcessor#11752
apupier wants to merge 1 commit into
apache:mainfrom
apupier:removeDeprecateGetOutInCamelStax

Conversation

@apupier
Copy link
Copy Markdown
Contributor

@apupier apupier commented Oct 18, 2023

Description

Target

  • I checked that the commit is targeting the correct branch (note that Camel 3 uses camel-3.x, whereas Camel 4 uses the main branch)

Tracking

  • If this is a large change, bug fix, or code improvement, I checked there is a JIRA issue filed for the change (usually before you start working on it).

Apache Camel coding standards and style

  • I checked that each commit in the pull request has a meaningful subject line and body.
  • I have run mvn clean install -DskipTests locally and I have committed all auto-generated changes

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@github-actions
Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Copy link
Copy Markdown
Contributor

@davsclaus davsclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not correct, the old code is correct

Otherwise all the code should just be

exchange.getMessage().setBody

to only change the body, and not copy over headers etc.

@apupier
Copy link
Copy Markdown
Contributor Author

apupier commented Oct 18, 2023

By what should it be replaced then? How to get rid of the deprecated method?

@davsclaus
Copy link
Copy Markdown
Contributor

By what should it be replaced then? How to get rid of the deprecated method?

Leave it as-is. The deprecation is for end users to not use it.
We will later in Camel 5 remove and change internal inside camel

@apupier apupier closed this Oct 18, 2023
@apupier apupier deleted the removeDeprecateGetOutInCamelStax branch May 26, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants