Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
},
"headers": {
"CamelMiloNodeIds": { "index": 0, "kind": "header", "displayName": "", "group": "producer", "label": "producer", "required": false, "javaType": "List", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The node ids.", "constantName": "org.apache.camel.component.milo.MiloConstants#HEADER_NODE_IDS" },
"await": { "index": 1, "kind": "header", "displayName": "", "group": "producer", "label": "producer", "required": false, "javaType": "Boolean", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The await setting for writes.", "constantName": "org.apache.camel.component.milo.MiloConstants#HEADER_AWAIT" }
"CamelMiloAwait": { "index": 1, "kind": "header", "displayName": "", "group": "producer", "label": "producer", "required": false, "javaType": "Boolean", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The await setting for writes.", "constantName": "org.apache.camel.component.milo.MiloConstants#HEADER_AWAIT" }
},
"properties": {
"endpointUri": { "index": 0, "kind": "path", "displayName": "Endpoint Uri", "group": "common", "label": "", "required": true, "type": "string", "javaType": "java.lang.String", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The OPC UA server endpoint" },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
},
"headers": {
"CamelMiloNodeIds": { "index": 0, "kind": "header", "displayName": "", "group": "producer", "label": "producer", "required": false, "javaType": "List", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The node ids.", "constantName": "org.apache.camel.component.milo.MiloConstants#HEADER_NODE_IDS" },
"await": { "index": 1, "kind": "header", "displayName": "", "group": "producer", "label": "producer", "required": false, "javaType": "Boolean", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The await setting for writes.", "constantName": "org.apache.camel.component.milo.MiloConstants#HEADER_AWAIT" }
"CamelMiloAwait": { "index": 1, "kind": "header", "displayName": "", "group": "producer", "label": "producer", "required": false, "javaType": "Boolean", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The await setting for writes.", "constantName": "org.apache.camel.component.milo.MiloConstants#HEADER_AWAIT" }
},
"properties": {
"endpointUri": { "index": 0, "kind": "path", "displayName": "Endpoint Uri", "group": "common", "label": "", "required": true, "type": "string", "javaType": "java.lang.String", "deprecated": false, "deprecationNote": "", "autowired": false, "secret": false, "description": "The OPC UA server endpoint" },
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public final class MiloConstants {
public static final String HEADER_NODE_IDS = "CamelMiloNodeIds";
@Metadata(label = "producer", description = "The \"await\" setting for writes.", javaType = "Boolean",
applicableFor = SCHEME_CLIENT)
public static final String HEADER_AWAIT = "await";
public static final String HEADER_AWAIT = "CamelMiloAwait";

private MiloConstants() {

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,6 @@ public void testWrite3() throws Exception {

private static void sendValue(final ProducerTemplate producerTemplate, final Variant variant) {
// we always write synchronously since we do need the message order
producerTemplate.sendBodyAndHeader(variant, "await", true);
producerTemplate.sendBodyAndHeader(variant, "CamelMiloAwait", true);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,6 @@ public void testCall1() {

private static void doCall(final ProducerTemplate producerTemplate, final Object input) {
// we always write synchronously since we do need the message order
producerTemplate.sendBodyAndHeader(input, "await", true);
producerTemplate.sendBodyAndHeader(input, "CamelMiloAwait", true);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -778,6 +778,32 @@ directions, aligning the component with the rest of the Camel component catalog.
`Camel`-prefixed user-header names from Iggy messages can supply a custom `headerFilterStrategy`
to restore the previous behaviour.

=== camel-milo - potential breaking change

The `MiloConstants.HEADER_AWAIT` constant, which controls whether milo-client
writes are awaited, used the header value `await` — outside the `Camel`
namespace and therefore not filtered by the default `HeaderFilterStrategy`. It
has been renamed to follow the Camel naming convention. The Java field name is
unchanged; only the header string value has changed:

[options="header"]
|===
| Constant | Previous value | New value
| `MiloConstants.HEADER_AWAIT` | `await` | `CamelMiloAwait`
|===

`MiloConstants.HEADER_NODE_IDS` was already `Camel`-prefixed
(`CamelMiloNodeIds`) and is unchanged.

Routes that reference the constant symbolically (for example
`setHeader(MiloConstants.HEADER_AWAIT, ...)`) continue to work without changes.
Routes that set the header by its literal string value (for example
`setHeader("await", ...)`) must be updated to use the new value
(`setHeader("CamelMiloAwait", ...)`).

As a consequence, the generated Endpoint DSL header accessor `await()` on
`MiloClientHeaderNameBuilder` has been renamed to `miloAwait()`.

=== Jackson dataformat documentation pages renamed

The Jackson 2.x and Jackson 3.x lines ship the same dataformat names (`jackson`, `jacksonXml`,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2351,10 +2351,10 @@ public String miloNodeIds() {
*
* Group: producer
*
* @return the name of the header {@code await}.
* @return the name of the header {@code MiloAwait}.
*/
public String await() {
return "await";
public String miloAwait() {
return "CamelMiloAwait";
}
}
static MiloClientEndpointBuilder endpointBuilder(String componentName, String path) {
Expand Down