CAMEL-23443: camel-pulsar - expose enableBatchIndexAcknowledgment#23485
Open
rkdfx wants to merge 1 commit into
Open
CAMEL-23443: camel-pulsar - expose enableBatchIndexAcknowledgment#23485rkdfx wants to merge 1 commit into
rkdfx wants to merge 1 commit into
Conversation
Signed-off-by: Ravi <13908473+rkdfx@users.noreply.github.com>
oscerd
approved these changes
May 23, 2026
gnodet
approved these changes
May 23, 2026
Contributor
gnodet
left a comment
There was a problem hiding this comment.
Clean, well-structured PR. The new enableBatchIndexAcknowledgment consumer option is properly implemented:
@UriParam(label = "consumer")with a clear description that documents the broker-side prerequisite (acknowledgmentAtBatchIndexLevelEnabled=true)- Default
falsematches the Pulsar client's own default — no behavior change for existing routes - Wired into
CommonCreationStrategyImplconsistently alongside the existingreadCompactedoption - Tests cover both the default value assertion and the URI-parsing path
- All generated files (catalog, configurers, URI factory) are committed
Looks good to merge.
Claude Code on behalf of Guillaume Nodet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new consumer-side URI option
enableBatchIndexAcknowledgmentto thecamel-pulsarcomponent.
The Pulsar client's
ConsumerBuildersupportsenableBatchIndexAcknowledgment(boolean)to allow each message in a batch to be acknowledgedindependently. With the option disabled (the Pulsar client default), a single failed
acknowledgment causes the broker to redeliver the entire batch — including messages that were
processed successfully. The component previously built the
ConsumerBuilderwithout invokingthis method and exposed no URI parameter to configure it.
This change:
@UriParam(label = "consumer")field onPulsarConfigurationwithdefault
false(matches the Pulsar client's own default — no behaviour change for existingroutes).
CommonCreationStrategyImplin the same shape as the existingreadCompactedoption (unconditional pass-through onto the
ConsumerBuilder).PulsarComponentTest.testPulsarEndpointDefaultConfigurationand a new URI-parsing test
testPulsarEndpointEnableBatchIndexAcknowledgment.Enabling this option also requires the Pulsar broker to be configured with
acknowledgmentAtBatchIndexLevelEnabled=truefor the per-message acknowledgments to takeeffect. This is documented in the option's description.
Resolves https://issues.apache.org/jira/browse/CAMEL-23443
Target
mainbranch)Tracking
Apache Camel coding standards and style
mvn clean install -DskipTestslocally from root folder and I have committed all auto-generated changes.