CLOUDSTACK-9203 Implement security group move on updateVM API call

  cherry-picked from a exoscale internal fix

Conflicts:
	api/src/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
	server/src/com/cloud/vm/UserVmManager.java
	server/src/com/cloud/vm/UserVmManagerImpl.java

Author: DaanHoogland

server/src/com/cloud/vm/UserVmManagerImpl.java

@@ -2455,35 +2455,19 @@ public UserVm updateVirtualMachine(long id, String displayName, String group, Bo
             isDynamicallyScalable = vm.isDynamicallyScalable();
         }
 
-        Network defaultNetwork = null;
+        // Get default guest network in Basic zone
         DataCenterVO zone = _dcDao.findById(vm.getDataCenterId());
-        if (zone.getNetworkType() == NetworkType.Basic) {
-            // Get default guest network in Basic zone
-            defaultNetwork = _networkModel.getExclusiveGuestNetwork(zone.getId());
-        } else if (zone.isSecurityGroupEnabled()) {
-            NicVO defaultNic = _nicDao.findDefaultNicForVM(vm.getId());
-            if (defaultNic != null) {
-                defaultNetwork = _networkDao.findById(defaultNic.getNetworkId());
-            }
-        }
-
-        if (defaultNetwork == null && (zone.getNetworkType() == NetworkType.Basic || zone.isSecurityGroupEnabled())) {
-            throw new InvalidParameterValueException("Cannot find default network for vm:" + vm.getId());
-        }
+        Network defaultNetwork = _networkModel.getExclusiveGuestNetwork(zone.getId());
 
         boolean isVmWare = (vm.getHypervisorType() == HypervisorType.VMware);
 
         if (securityGroupIdList != null && isVmWare) {
             throw new InvalidParameterValueException("Security group feature is not supported for vmWare hypervisor");
         } else if (securityGroupIdList != null && _networkModel.isSecurityGroupSupportedInNetwork(defaultNetwork) && _networkModel.canAddDefaultSecurityGroup()) {
-            if (vm.getState() == State.Stopped) {
-                // Remove instance from security groups
-                _securityGroupMgr.removeInstanceFromGroups(id);
-                // Add instance in provided groups
-                _securityGroupMgr.addInstanceToGroups(id, securityGroupIdList);
-            } else {
-                throw new InvalidParameterValueException("Virtual machine must be stopped prior to update security groups ");
-            }
+            // Remove instance from security groups
+            _securityGroupMgr.removeInstanceFromGroups(id);
+            // Add instance in provided groups
+            _securityGroupMgr.addInstanceToGroups(id, securityGroupIdList);
         }
 
         if (hostName != null) {