UI: create VPC network offering with conserve mode

[weizhouapache]

Description

The default offering for vpc networks has been changed to conserved mode in PR #8309 . It looks good.
This PR enables the option on UI

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.03%. Comparing base (e57a82a) to head (d7adf5d).
Report is 5 commits behind head on 4.20.

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #10082   +/-   ##
=========================================
  Coverage     16.03%   16.03%           
- Complexity    12814    12815    +1     
=========================================
  Files          5637     5637           
  Lines        493506   493506           
  Branches      59831    59831           
=========================================
+ Hits          79129    79130    +1     
+ Misses       405601   405600    -1     
  Partials       8776     8776           

Flag	Coverage Δ
uitests	4.02% <ø> (ø)
unittests	16.87% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JoaoJandre]

@blueorangutan ui

[blueorangutan]

@JoaoJandre a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

[blueorangutan]

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10082 (QA-JID-501)

[DaanHoogland]

@weizhouapache , any reason this should be on 4.20 and not 4.19?

[weizhouapache]

@weizhouapache , any reason this should be on 4.20 and not 4.19?

as the line of code is different in 4.19/4.20

@@ -377,7 +452,7 @@
         <a-form-item
           name="conservemode"
           ref="conservemode"
-          v-if="(guestType === 'shared' || guestType === 'isolated') && !isVpcVirtualRouterForAtLeastOneService">
+          v-if="(guestType === 'shared' || guestType === 'isolated') && !isVpcVirtualRouterForAtLeastOneService && !forNsx && networkmode !== 'ROUTED'">
           <template #label>
             <tooltip-label :title="$t('label.conservemode')" :tooltip="apiParams.conservemode.description"/>
           </template>

I can rebase to 4.19 if you think it is needed. (then you will face merge conflict when merge forward 😄 )

[DaanHoogland]

@weizhouapache , any reason this should be on 4.20 and not 4.19?

as the line of code is different in 4.19/4.20

@@ -377,7 +452,7 @@
         <a-form-item
           name="conservemode"
           ref="conservemode"
-          v-if="(guestType === 'shared' || guestType === 'isolated') && !isVpcVirtualRouterForAtLeastOneService">
+          v-if="(guestType === 'shared' || guestType === 'isolated') && !isVpcVirtualRouterForAtLeastOneService && !forNsx && networkmode !== 'ROUTED'">
           <template #label>
             <tooltip-label :title="$t('label.conservemode')" :tooltip="apiParams.conservemode.description"/>
           </template>

I can rebase to 4.19 if you think it is needed. (then you will face merge conflict when merge forward 😄 )

thanks, I think I wil live with it ;) but it should not be a big deal.

[JoaoJandre]

LGTM, tested creating both VPC network offerings with and without conserve mode, both were correctly created