From 05d2d1bed02176a8cec20398d62341480f717508 Mon Sep 17 00:00:00 2001 From: Vipul Vaibhaw Date: Sun, 19 May 2024 21:36:19 +0530 Subject: [PATCH] removing leading whitespaces --- .../org/apache/comet/expressions/CometCast.scala | 5 ++--- .../test/scala/org/apache/comet/CometCastSuite.scala | 11 ++++++++--- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/spark/src/main/scala/org/apache/comet/expressions/CometCast.scala b/spark/src/main/scala/org/apache/comet/expressions/CometCast.scala index 9c3695ba51..2ef9c6c09d 100644 --- a/spark/src/main/scala/org/apache/comet/expressions/CometCast.scala +++ b/spark/src/main/scala/org/apache/comet/expressions/CometCast.scala @@ -104,10 +104,9 @@ object CometCast { timeZoneId: Option[String], evalMode: String): SupportLevel = { toType match { - case DataTypes.BooleanType => + case DataTypes.BooleanType | DataTypes.IntegerType => Compatible() - case DataTypes.ByteType | DataTypes.ShortType | DataTypes.IntegerType | - DataTypes.LongType => + case DataTypes.ByteType | DataTypes.ShortType | DataTypes.LongType => Incompatible(Some("Not all invalid inputs are detected")) case DataTypes.BinaryType => Compatible() diff --git a/spark/src/test/scala/org/apache/comet/CometCastSuite.scala b/spark/src/test/scala/org/apache/comet/CometCastSuite.scala index ea3355d054..487beaeacf 100644 --- a/spark/src/test/scala/org/apache/comet/CometCastSuite.scala +++ b/spark/src/test/scala/org/apache/comet/CometCastSuite.scala @@ -23,7 +23,7 @@ import java.io.File import scala.util.Random -import org.apache.spark.sql.{CometTestBase, DataFrame, SaveMode} +import org.apache.spark.sql.{functions, CometTestBase, DataFrame, SaveMode} import org.apache.spark.sql.catalyst.expressions.Cast import org.apache.spark.sql.execution.adaptive.AdaptiveSparkPlanHelper import org.apache.spark.sql.functions.col @@ -533,11 +533,16 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper { castTest(gen.generateStrings(dataSize, numericPattern, 5).toDF("a"), DataTypes.ShortType) } - ignore("cast StringType to IntegerType") { + test("cast StringType to IntegerType") { // test with hand-picked values castTest(castStringToIntegralInputs.toDF("a"), DataTypes.IntegerType) // fuzz test - castTest(gen.generateStrings(dataSize, numericPattern, 8).toDF("a"), DataTypes.IntegerType) + castTest( + gen + .generateStrings(dataSize, numericPattern, 8) + .toDF("a") + .withColumn("a", functions.trim($"a")), + DataTypes.IntegerType) } ignore("cast StringType to LongType") {