CI: Add a new run to check whether lock file is up-to-date

Author: isidentical

.github/workflows/rust.yml

@@ -356,6 +356,15 @@ jobs:
           rustup component add clippy
       - name: Run clippy
         run: ci/scripts/rust_clippy.sh
+      - name: Check Cargo.lock for datafusion-cli
+        run: |
+          # This operation is not particularly expensive, but it is not free either
+          # and since this happens very rarely we can simply guard it off for the
+          # cases where Cargo.toml has changed.
+          git diff --name-only origin/$GITHUB_BASE_REF.. \
+            | grep -qE 'Cargo.toml' \
+            && ./ci/scripts/rust_cargo_lock.sh \
+            || true
 
   # Check answers are correct when hash values collide
   hash-collisions:

.gitignore

@@ -85,7 +85,6 @@ cpp/Brewfile.lock.json
 target
 Cargo.lock
 !datafusion-cli/Cargo.lock
-!ballista-cli/Cargo.lock
 
 rusty-tags.vi
 .history

ci/scripts/rust_cargo_lock.sh

@@ -0,0 +1,23 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Check whether the Cargo.lock is up-to-date in the datafusion-cli
+# since it is the only crate that has a Cargo.lock file checked in.
+set -ex
+cargo check --manifest-path datafusion-cli/Cargo.toml --locked