Skip to content

Commit 6e7390f

Browse files
committed
Remove IMDB(JOB) slt in CI
Signed-off-by: Austin Liu <austin362667@gmail.com>
1 parent 6ee3e89 commit 6e7390f

22 files changed

+4
-729
lines changed

.github/workflows/rust.yml

Lines changed: 4 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -252,9 +252,9 @@ jobs:
252252
working-directory: ./datafusion/wasmtest
253253
run: wasm-pack build --dev
254254

255-
# verify that tpch benchmark queries return the correct results
256-
verify-tpch-benchmark-results:
257-
name: verify tpch benchmark results (amd64)
255+
# verify that the benchmark queries return the correct results
256+
verify-benchmark-results:
257+
name: verify benchmark results (amd64)
258258
needs: [ linux-build-lib ]
259259
runs-on: ubuntu-latest
260260
container:
@@ -280,33 +280,7 @@ jobs:
280280
export TPCH_DATA=`realpath datafusion/sqllogictest/test_files/tpch/data`
281281
# use release build for plan verificaton because debug build causes stack overflow
282282
cargo test plan_q --package datafusion-benchmarks --profile release-nonlto --features=ci -- --test-threads=1
283-
INCLUDE_TPCH=true cargo test --test sqllogictests -- tpch
284-
- name: Verify Working Directory Clean
285-
run: git diff --exit-code
286-
287-
# verify that imdb benchmark queries return the correct results
288-
verify-imdb-benchmark-results:
289-
name: verify imdb benchmark results (amd64)
290-
needs: [ linux-build-lib ]
291-
runs-on: ubuntu-latest
292-
container:
293-
image: amd64/rust
294-
steps:
295-
- uses: actions/checkout@v4
296-
with:
297-
submodules: true
298-
- name: Setup Rust toolchain
299-
uses: ./.github/actions/setup-builder
300-
with:
301-
rust-version: stable
302-
- name: Download benchmark data and expected query results
303-
run: |
304-
benchmarks/bench.sh data imdb
305-
- name: Verify that benchmark queries return expected results
306-
run: |
307-
INCLUDE_IMDB=true cargo test --test sqllogictests -- imdb
308-
- name: Verify Working Directory Clean
309-
run: git diff --exit-code
283+
INCLUDE_TPCH=true cargo test --test sqllogictests
310284
311285
sqllogictest-postgres:
312286
name: "Run sqllogictest with Postgres runner"

datafusion/sqllogictest/bin/sqllogictests.rs

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -231,14 +231,6 @@ impl TestFile {
231231

232232
options.include_tpch
233233
}
234-
235-
fn check_imdb(&self, options: &Options) -> bool {
236-
if !self.relative_path.starts_with("imdb") {
237-
return true;
238-
}
239-
240-
options.include_imdb
241-
}
242234
}
243235

244236
fn read_test_files<'a>(
@@ -251,7 +243,6 @@ fn read_test_files<'a>(
251243
.filter(|f| options.check_test_file(&f.relative_path))
252244
.filter(|f| f.is_slt_file())
253245
.filter(|f| f.check_tpch(options))
254-
.filter(|f| f.check_imdb(options))
255246
.filter(|f| options.check_pg_compat_file(f.path.as_path())),
256247
))
257248
}
@@ -305,9 +296,6 @@ struct Options {
305296
#[clap(long, env = "INCLUDE_TPCH", help = "Include tpch files")]
306297
include_tpch: bool,
307298

308-
#[clap(long, env = "INCLUDE_IMDB", help = "Include imdb files")]
309-
include_imdb: bool,
310-
311299
#[clap(
312300
action,
313301
help = "regex like arguments passed to the program which are treated as cargo test filter (substring match on filenames)"

datafusion/sqllogictest/test_files/imdb/1a.slt.part

Lines changed: 0 additions & 22 deletions
This file was deleted.

datafusion/sqllogictest/test_files/imdb/1b.slt.part

Lines changed: 0 additions & 22 deletions
This file was deleted.

datafusion/sqllogictest/test_files/imdb/1c.slt.part

Lines changed: 0 additions & 22 deletions
This file was deleted.

datafusion/sqllogictest/test_files/imdb/1d.slt.part

Lines changed: 0 additions & 22 deletions
This file was deleted.

datafusion/sqllogictest/test_files/imdb/2a.slt.part

Lines changed: 0 additions & 22 deletions
This file was deleted.

datafusion/sqllogictest/test_files/imdb/2b.slt.part

Lines changed: 0 additions & 22 deletions
This file was deleted.

datafusion/sqllogictest/test_files/imdb/2c.slt.part

Lines changed: 0 additions & 22 deletions
This file was deleted.

datafusion/sqllogictest/test_files/imdb/2d.slt.part

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)