Commit 8698d95
authored
Extract complex default impls from AggregateUDFImpl trait (#17391)
* Extract complex default impls from AggregateUDFImpl trait
Extract AggregateUDFImpl method that have complex implementations. This
makes it feasible to implement that trait with
`#[warn(clippy::missing_trait_methods)]` Clippy check enabled. That
check is very helpful when the type implementing `AggregateUDFImpl`
delegates many methods to another `AggregateUDFImpl` implementation and
therefore does not want to unconsciously rely on default implementation.
Sadly, Rust does not allow explicitly delegating to trait method's
default implementation. Extracting the logic to standalone functions
works around that limitation.
* Docs1 parent 9942ecd commit 8698d95
2 files changed
+282
-233
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
109 | | - | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
110 | 112 | | |
111 | 113 | | |
112 | 114 | | |
| |||
0 commit comments