Skip to content

feat: Simplify CASE WHEN true THEN expr to expr #17450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 5 commits into from
Sep 16, 2025
Merged

feat: Simplify CASE WHEN true THEN expr to expr #17450

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b9ad3cd
feat: Simplify CASE WHEN true THEN expr to expr
Sep 5, 2025
c96037d
Address review feedback for CASE WHEN true simplification
Sep 13, 2025
bd2e16a
Merge remote-tracking branch 'apache/main' into fix-case-when-true-si…
alamb Sep 15, 2025
f3ae623
Update test
alamb Sep 15, 2025
5ac72b8
fmt
alamb Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fmt
  • Loading branch information
@alamb
alamb committed Sep 15, 2025
commit 5ac72b85274b2c33f61249b6b97feab4dea79ea0
19 changes: 4 additions & 15 deletions datafusion/optimizer/src/simplify_expressions/expr_simplifier.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1404,9 +1404,7 @@ impl<S: SimplifyInfo> TreeNodeRewriter for Simplifier<'_, S> {
expr: None,
mut when_then_expr,
else_expr: _,
}) if !when_then_expr.is_empty()
&& is_true(when_then_expr[0].0.as_ref()) =>
{
}) if !when_then_expr.is_empty() && is_true(when_then_expr[0].0.as_ref()) => {
let (_, then_) = when_then_expr.swap_remove(0);
Transformed::yes(*then_)
}
Expand Down Expand Up @@ -3570,10 +3568,7 @@ mod tests {
assert_eq!(
simplify(Expr::Case(Case::new(
None,
vec![(
Box::new(lit(true)),
Box::new(lit(1)),
)],
vec![(Box::new(lit(true)), Box::new(lit(1)),)],
Some(Box::new(col("x"))),
))),
lit(1)
Expand All @@ -3583,10 +3578,7 @@ mod tests {
assert_eq!(
simplify(Expr::Case(Case::new(
None,
vec![(
Box::new(lit(true)),
Box::new(col("a")),
)],
vec![(Box::new(lit(true)), Box::new(col("a")),)],
Some(Box::new(col("b"))),
))),
col("a")
Expand All @@ -3609,10 +3601,7 @@ mod tests {
assert_eq!(
simplify(Expr::Case(Case::new(
None,
vec![(
Box::new(lit(true)),
Box::new(col("a")),
)],
vec![(Box::new(lit(true)), Box::new(col("a")),)],
None,
))),
col("a")
Expand Down