From 0a08225e1185cd8ba822ab024dd40a72a98e5cc0 Mon Sep 17 00:00:00 2001 From: morningman Date: Fri, 1 Nov 2024 21:43:22 +0800 Subject: [PATCH] 1 --- .../src/main/java/org/apache/doris/analysis/ExportStmt.java | 2 +- fe/fe-core/src/main/java/org/apache/doris/load/ExportJob.java | 4 ++-- fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java | 4 +--- .../doris/nereids/trees/plans/commands/ExportCommand.java | 2 +- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java b/fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java index 855379cbc37e71..581dff1917b194 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java +++ b/fe/fe-core/src/main/java/org/apache/doris/analysis/ExportStmt.java @@ -208,7 +208,7 @@ public void analyze(Analyzer analyzer) throws UserException { } private void setJob() throws UserException { - exportJob = new ExportJob(); + exportJob = new ExportJob(Env.getCurrentEnv().getNextId()); Database db = Env.getCurrentInternalCatalog().getDbOrDdlException(this.tblName.getDb()); exportJob.setDbId(db.getId()); diff --git a/fe/fe-core/src/main/java/org/apache/doris/load/ExportJob.java b/fe/fe-core/src/main/java/org/apache/doris/load/ExportJob.java index 21df83c119227a..e04472f43dffbf 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/load/ExportJob.java +++ b/fe/fe-core/src/main/java/org/apache/doris/load/ExportJob.java @@ -397,8 +397,8 @@ private StatementBase generateLogicalPlanAdapter(LogicalPlan outfileLogicalPlan) return statementBase; } - public List getTaskExecutors() { - return jobExecutorList; + public List getCopiedTaskExecutors() { + return Lists.newArrayList(jobExecutorList); } private void generateExportJobExecutor() { diff --git a/fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java b/fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java index 2c0a6ec5916ae2..876dcf9def49e9 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java +++ b/fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java @@ -95,8 +95,6 @@ private void writeUnlock() { } public void addExportJobAndRegisterTask(ExportJob job) throws Exception { - long jobId = Env.getCurrentEnv().getNextId(); - job.setId(jobId); writeLock(); try { if (dbTolabelToExportJobId.containsKey(job.getDbId()) @@ -113,7 +111,7 @@ public void addExportJobAndRegisterTask(ExportJob job) throws Exception { BrokerUtil.deleteDirectoryWithFileSystem(fullPath.substring(0, fullPath.lastIndexOf('/') + 1), job.getBrokerDesc()); } - job.getTaskExecutors().forEach(executor -> { + job.getCopiedTaskExecutors().forEach(executor -> { Env.getCurrentEnv().getTransientTaskManager().addMemoryTask(executor); }); Env.getCurrentEnv().getEditLog().logExportCreate(job); diff --git a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ExportCommand.java b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ExportCommand.java index 263bf43e355dc6..fd5d604c5204b9 100644 --- a/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ExportCommand.java +++ b/fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ExportCommand.java @@ -241,7 +241,7 @@ private void checkBrokerDesc(ConnectContext ctx) throws UserException { private ExportJob generateExportJob(ConnectContext ctx, Map fileProperties, TableName tblName) throws UserException { - ExportJob exportJob = new ExportJob(); + ExportJob exportJob = new ExportJob(Env.getCurrentEnv().getNextId()); // set export job and check catalog/db/table CatalogIf catalog = ctx.getEnv().getCatalogMgr().getCatalogOrAnalysisException(tblName.getCtl()); DatabaseIf db = catalog.getDbOrAnalysisException(tblName.getDb());