Skip to content

Commit 83a0c54

Browse files
minor tests refactor
1 parent d1d590a commit 83a0c54

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

tests/catalog/test_sql.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1138,7 +1138,8 @@ def test_namespace_exists(catalog: SqlCatalog) -> None:
11381138
def test_list_namespaces(catalog: SqlCatalog) -> None:
11391139
namespace_list = ["db", "db.ns1", "db.ns1.ns2", "db.ns2", "db2", "db2.ns1", "db%", "db.ns1X.ns3"]
11401140
for namespace in namespace_list:
1141-
catalog.create_namespace(namespace)
1141+
if not catalog._namespace_exists(namespace):
1142+
catalog.create_namespace(namespace)
11421143

11431144
ns_list = catalog.list_namespaces()
11441145
for ns in [("db",), ("db%",), ("db2",)]:
@@ -1183,13 +1184,13 @@ def test_list_non_existing_namespaces(catalog: SqlCatalog) -> None:
11831184
def test_drop_namespace(catalog: SqlCatalog, table_schema_nested: Schema, table_identifier: Identifier) -> None:
11841185
namespace = Catalog.namespace_from(table_identifier)
11851186
catalog.create_namespace(namespace)
1186-
assert namespace[:1] in catalog.list_namespaces()
1187+
assert catalog._namespace_exists(namespace)
11871188
catalog.create_table(table_identifier, table_schema_nested)
11881189
with pytest.raises(NamespaceNotEmptyError):
11891190
catalog.drop_namespace(namespace)
11901191
catalog.drop_table(table_identifier)
11911192
catalog.drop_namespace(namespace)
1192-
assert namespace[:1] not in catalog.list_namespaces()
1193+
assert not catalog._namespace_exists(namespace)
11931194

11941195

11951196
@pytest.mark.parametrize(

0 commit comments

Comments
 (0)