From b36c5d581c2e9d4c4e848e84737217f156b4acd9 Mon Sep 17 00:00:00 2001 From: Yuya Ebihara Date: Tue, 2 Dec 2025 13:19:52 +0900 Subject: [PATCH] Test: Use `@TempDir` in TestTableMetadataParser --- .../apache/iceberg/TestTableMetadataParser.java | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/core/src/test/java/org/apache/iceberg/TestTableMetadataParser.java b/core/src/test/java/org/apache/iceberg/TestTableMetadataParser.java index 87c618b9adcd..45333a4dde83 100644 --- a/core/src/test/java/org/apache/iceberg/TestTableMetadataParser.java +++ b/core/src/test/java/org/apache/iceberg/TestTableMetadataParser.java @@ -29,7 +29,6 @@ import java.io.IOException; import java.io.InputStream; import java.nio.file.Path; -import java.nio.file.Paths; import java.util.Arrays; import java.util.List; import java.util.Map; @@ -39,9 +38,9 @@ import org.apache.iceberg.io.OutputFile; import org.apache.iceberg.relocated.com.google.common.collect.Maps; import org.apache.iceberg.types.Types.BooleanType; -import org.junit.jupiter.api.AfterEach; import org.junit.jupiter.api.TestTemplate; import org.junit.jupiter.api.extension.ExtendWith; +import org.junit.jupiter.api.io.TempDir; @ExtendWith(ParameterizedTestExtension.class) public class TestTableMetadataParser { @@ -56,10 +55,10 @@ private static List parameters() { @Parameter private String codecName; @TestTemplate - public void testGzipCompressionProperty() throws IOException { + public void testGzipCompressionProperty(@TempDir Path tempDir) throws IOException { Codec codec = Codec.fromName(codecName); String fileExtension = getFileExtension(codec); - String fileName = "v3" + fileExtension; + String fileName = tempDir + "/v3" + fileExtension; OutputFile outputFile = Files.localOutput(fileName); Map properties = Maps.newHashMap(); properties.put(TableProperties.METADATA_COMPRESSION, codecName); @@ -71,13 +70,6 @@ public void testGzipCompressionProperty() throws IOException { verifyMetadata(metadata, actualMetadata); } - @AfterEach - public void cleanup() throws IOException { - Codec codec = Codec.fromName(codecName); - Path metadataFilePath = Paths.get("v3" + getFileExtension(codec)); - java.nio.file.Files.deleteIfExists(metadataFilePath); - } - private void verifyMetadata(TableMetadata expected, TableMetadata actual) { assertThat(actual.schema().asStruct()).isEqualTo(expected.schema().asStruct()); assertThat(actual.location()).isEqualTo(expected.location());