Skip to content

Core: Add v4 TrackedFileAdapters to bridge Data/Delete Files #16100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rdblue merged 21 commits into from
Jun 11, 2026
Merged

Core: Add v4 TrackedFileAdapters to bridge Data/Delete Files #16100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
f5712cd
[core] v4: Add TrackedFileAdapters: bridge TrackedFile to DataFile/De…
anoopj Apr 22, 2026
8a2fff3
Clean up tests
anoopj Apr 24, 2026
8da8824
Change design such that a DV adapted to DeleteFile
anoopj Apr 28, 2026
ce43f60
Make copy safe
anoopj Apr 28, 2026
cecdbef
Reorder
anoopj Apr 28, 2026
e965dec
Feedback from Ryan
anoopj May 5, 2026
712f53d
fix checksytle error
anoopj May 5, 2026
bf6f526
Feedback from Eduard, Steven, Ryan
anoopj May 6, 2026
d6e317f
Incorporate PR feedback
anoopj May 11, 2026
eedacf2
support v3 DVs through the adapter
anoopj May 11, 2026
d85fecd
Revert the whole v3 DV adapter
anoopj May 12, 2026
8d3473e
Feedback
anoopj May 12, 2026
6e4ea18
Fix comment
anoopj May 12, 2026
c12e004
Fix failure
anoopj May 12, 2026
7a528f8
Rebase
anoopj May 12, 2026
5d758b2
Fix spotless
anoopj May 12, 2026
033c69c
Fix ordinals after rebasing
anoopj May 13, 2026
bd9c6bf
Remove position delete from adapter
anoopj May 14, 2026
9fa6e79
Incorporate feedback from Ryan
anoopj Jun 8, 2026
ad06118
PR feedback
anoopj Jun 10, 2026
31c5726
Feedback
anoopj Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 76 additions & 0 deletions core/src/main/java/org/apache/iceberg/MetricsUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import static org.apache.iceberg.types.Types.NestedField.optional;

import java.nio.ByteBuffer;
import java.util.Collections;
import java.util.Comparator;
import java.util.List;
import java.util.Map;
Expand Down Expand Up @@ -479,6 +480,81 @@ public <T> void set(int pos, T value) {
}
}

static Map<Integer, Long> valueCounts(ContentStats stats) {
if (stats == null) {
return null;
}

Map<Integer, Long> result = Maps.newHashMap();
for (FieldStats<?> fs : stats.fieldStats()) {
if (fs != null && fs.valueCount() != null) {
result.put(fs.fieldId(), fs.valueCount());
}
}

return result.isEmpty() ? null : Collections.unmodifiableMap(result);
}

static Map<Integer, Long> nullValueCounts(ContentStats stats) {
if (stats == null) {
return null;
}

Map<Integer, Long> result = Maps.newHashMap();
for (FieldStats<?> fs : stats.fieldStats()) {
if (fs != null && fs.nullValueCount() != null) {
result.put(fs.fieldId(), fs.nullValueCount());
}
}

return result.isEmpty() ? null : Collections.unmodifiableMap(result);
}

static Map<Integer, Long> nanValueCounts(ContentStats stats) {
if (stats == null) {
return null;
}

Map<Integer, Long> result = Maps.newHashMap();
for (FieldStats<?> fs : stats.fieldStats()) {
if (fs != null && fs.nanValueCount() != null) {
result.put(fs.fieldId(), fs.nanValueCount());
}
}

return result.isEmpty() ? null : Collections.unmodifiableMap(result);
}

static Map<Integer, ByteBuffer> lowerBounds(ContentStats stats) {
if (stats == null) {
return null;
}

Map<Integer, ByteBuffer> result = Maps.newHashMap();
for (FieldStats<?> fs : stats.fieldStats()) {
if (fs != null && fs.lowerBound() != null && fs.type() != null) {
result.put(fs.fieldId(), Conversions.toByteBuffer(fs.type(), fs.lowerBound()));
}
}

return result.isEmpty() ? null : Collections.unmodifiableMap(result);
}

static Map<Integer, ByteBuffer> upperBounds(ContentStats stats) {
if (stats == null) {
return null;
}

Map<Integer, ByteBuffer> result = Maps.newHashMap();
for (FieldStats<?> fs : stats.fieldStats()) {
if (fs != null && fs.upperBound() != null && fs.type() != null) {
result.put(fs.fieldId(), Conversions.toByteBuffer(fs.type(), fs.upperBound()));
}
}

return result.isEmpty() ? null : Collections.unmodifiableMap(result);
}

static ContentStats fromMetrics(Schema schema, Metrics metrics) {
if (null == metrics) {
return null;
Expand Down
Loading