Core: Fix NPE in CloseableIterable.close()#6322
Merged
Merged
Conversation
Member
|
@nastra thank you for the fix. Note that build isn't green |
Contributor
Author
d4dadff to
e379c8b
Compare
stevenzwu
approved these changes
Nov 30, 2022
stevenzwu
reviewed
Nov 30, 2022
| } | ||
|
|
||
| @Test | ||
| public void concatIterablesWithIterator() throws IOException { |
Contributor
There was a problem hiding this comment.
nit: this method name can be more descriptive, sth like testCloseWithEmptyIterables
Contributor
Author
There was a problem hiding this comment.
I specifically avoid naming it like this, because the important piece where this NPE is happening is the usage of .iterator() before doing a .close()
ajantha-bhat
approved these changes
Dec 1, 2022
danielcweeks
approved these changes
Dec 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be reproduced by running: