Pull #2282: Add project icon for IntelliJ IDEA
#2283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elharo
requested changes
May 5, 2025
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
.idea is in our .gitignore file. Not sure what to do about that, but it needs to be addressed.
Contributor
Author
|
.Editorconfig project has an issue for this feature to be generic, but it’s taking some time to be ready. Yes IDE specific stuff is not nice, that’s why it’s limited to one uncritical file only. In this case it’s an exception, that all projects have to apply, if they want to shine ✨. It’s possible to add this file and still ignore changes on this.It’s then in the repo, like it was added before the ignore.Sent from my iPhoneOn 5 May 2025, at 12:38, Elliotte Rusty Harold ***@***.***> wrote:
@elharo requested changes on this pull request.
.idea is in our .gitignore file. Not sure what to do about that, but it needs to be addressed.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
elharo
requested changes
May 5, 2025
Contributor
Author
|
done |
elharo
approved these changes
May 6, 2025
Contributor
Author
|
thx |
Contributor
Author
|
FYI: @romani @nrmancuso |
Pankraz76
changed the title
Add project icon for IntelliJ IDEAIntelliJ IDEA
Contributor
Author
|
whats your call on this @gnodet? might be rdy to merge and gain feedback. |
Contributor
Author
|
awesome, thank you. |
This was referenced Jun 24, 2025
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull #2282: Add project icon for
IntelliJ IDEAproject iconforIntelliJ IDEAcheckstyle/checkstyle#16813project iconforIntelliJ IDEAcheckstyle/checkstyle#16815