From 16f75d23c523c1332e968c6ed239879584601575 Mon Sep 17 00:00:00 2001 From: Michael Marshall Date: Tue, 16 Nov 2021 23:57:19 -0600 Subject: [PATCH] [Java Client] Make userProvidedProducerName final --- .../java/org/apache/pulsar/client/impl/ProducerImpl.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java index 3db270ca4f507..48965d893eb81 100644 --- a/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java +++ b/pulsar-client/src/main/java/org/apache/pulsar/client/impl/ProducerImpl.java @@ -115,7 +115,7 @@ public class ProducerImpl extends ProducerBase implements TimerTask, Conne // Globally unique producer name private String producerName; - private boolean userProvidedProducerName = false; + private final boolean userProvidedProducerName; private String connectionId; private String connectedSince; @@ -161,9 +161,7 @@ public ProducerImpl(PulsarClientImpl client, String topic, ProducerConfiguration super(client, topic, conf, producerCreatedFuture, schema, interceptors); this.producerId = client.newProducerId(); this.producerName = conf.getProducerName(); - if (StringUtils.isNotBlank(producerName)) { - this.userProvidedProducerName = true; - } + this.userProvidedProducerName = StringUtils.isNotBlank(producerName); this.partitionIndex = partitionIndex; this.pendingMessages = createPendingMessagesQueue(); if (conf.getMaxPendingMessages() > 0) {