From e8dcc6a994372417eefc99310032e299f0b355fd Mon Sep 17 00:00:00 2001 From: chenlin <1572139390@qq.com> Date: Mon, 17 Jan 2022 00:56:13 +0800 Subject: [PATCH 1/2] clean unused method: getRangeConsumer --- .../service/ConsistentHashingStickyKeyConsumerSelector.java | 4 ---- .../service/HashRangeAutoSplitStickyKeyConsumerSelector.java | 4 ---- 2 files changed, 8 deletions(-) diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java index 7b7a8307baa45..c08489185f9af 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java @@ -144,8 +144,4 @@ public Map> getConsumerKeyHashRanges() { } return result; } - - Map> getRangeConsumer() { - return Collections.unmodifiableMap(hashRing); - } } diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/HashRangeAutoSplitStickyKeyConsumerSelector.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/HashRangeAutoSplitStickyKeyConsumerSelector.java index 5cf36ee5d7520..3628d30ebc977 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/HashRangeAutoSplitStickyKeyConsumerSelector.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/HashRangeAutoSplitStickyKeyConsumerSelector.java @@ -160,8 +160,4 @@ private boolean is2Power(int num) { } return (num & num - 1) == 0; } - - Map getRangeConsumer() { - return Collections.unmodifiableMap(rangeMap); - } } From 338a18f43a8c3f60361b19a1b4c53c5f79878bf3 Mon Sep 17 00:00:00 2001 From: penghui Date: Wed, 26 Jan 2022 11:20:07 +0800 Subject: [PATCH 2/2] Fix checkstyle --- .../service/ConsistentHashingStickyKeyConsumerSelector.java | 1 - .../service/HashRangeAutoSplitStickyKeyConsumerSelector.java | 1 - 2 files changed, 2 deletions(-) diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java index c08489185f9af..ea01af72eedb0 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ConsistentHashingStickyKeyConsumerSelector.java @@ -20,7 +20,6 @@ import com.google.common.collect.Lists; import java.util.ArrayList; -import java.util.Collections; import java.util.Comparator; import java.util.LinkedHashMap; import java.util.List; diff --git a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/HashRangeAutoSplitStickyKeyConsumerSelector.java b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/HashRangeAutoSplitStickyKeyConsumerSelector.java index 3628d30ebc977..7d19388a9b3b5 100644 --- a/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/HashRangeAutoSplitStickyKeyConsumerSelector.java +++ b/pulsar-broker/src/main/java/org/apache/pulsar/broker/service/HashRangeAutoSplitStickyKeyConsumerSelector.java @@ -19,7 +19,6 @@ package org.apache.pulsar.broker.service; import java.util.ArrayList; -import java.util.Collections; import java.util.HashMap; import java.util.List; import java.util.Map;