From 451dddb65257cdac11f926766e7d50ab5354cc13 Mon Sep 17 00:00:00 2001 From: Yong Zhang Date: Tue, 23 Jun 2020 18:28:27 +0800 Subject: [PATCH 1/2] Add more detail information of retry errors --- *Motivation* Currently, when you connecting to a wrong address, the error log does not show the detail information to let you know why it failed. Add the failed reason to know more about the error. Before adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted. ``` After adding the error log: ``` bin/pulsar-admin topics list public/default null Reason: java.util.concurrent.CompletionException: org.apache.pulsar.client.admin.internal.http.AsyncHttpConnector$RetryException: Could not complete the operation. Number of retries has been exhausted.Connection refused: localhost/127.0.0.1:8081 ``` --- .../pulsar/client/admin/internal/http/AsyncHttpConnector.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java b/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java index eca18003c4bec..755fdaa8a862a 100644 --- a/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java +++ b/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java @@ -241,7 +241,7 @@ private void retryOperation( } else { resultFuture.completeExceptionally( new RetryException("Could not complete the operation. Number of retries " - + "has been exhausted.", throwable)); + + "has been exhausted. Failed reason: " + throwable.getMessage(), throwable)); } } } else { From 05a82cdd597d3e24ef24cb5041c425a8b2eff586 Mon Sep 17 00:00:00 2001 From: Yong Zhang Date: Mon, 29 Jun 2020 09:19:00 +0800 Subject: [PATCH 2/2] Fix style --- .../client/admin/internal/http/AsyncHttpConnector.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java b/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java index 755fdaa8a862a..c0dc467c15e18 100644 --- a/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java +++ b/pulsar-client-admin/src/main/java/org/apache/pulsar/client/admin/internal/http/AsyncHttpConnector.java @@ -240,8 +240,9 @@ private void retryOperation( retries - 1); } else { resultFuture.completeExceptionally( - new RetryException("Could not complete the operation. Number of retries " - + "has been exhausted. Failed reason: " + throwable.getMessage(), throwable)); + new RetryException("Could not complete the operation. Number of retries " + + "has been exhausted. Failed reason: " + throwable.getMessage(), + throwable)); } } } else {