fix(pivot-table): fetch percent-mode denominator levels regardless of totals toggle

`showValuesAs` percent modes (% of row/column/grand total) divide by a
rollup level that `buildGroupbyCombinations` only queried when the
matching Total/subtotal display toggle was on, so picking a percent
mode without enabling that toggle could crash on a missing denominator
aggregator. Force the required level(s) in and fall back to a blank
cell instead of throwing if one is ever still missing.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: rusackas

superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/utilities.ts

@@ -18,7 +18,12 @@
  */
 
 import { QueryFormColumn, QueryFormMetric } from '@superset-ui/core';
-import { Groupby, MetricsLayoutEnum, PivotTableQueryFormData } from '../types';
+import {
+  Groupby,
+  MetricsLayoutEnum,
+  PivotTableQueryFormData,
+  ShowValuesAsEnum,
+} from '../types';
 
 // Aggregates whose group total can be derived from per-group results
 // (decomposable): summing sub-sums, counting sub-counts, min-of-mins,
@@ -189,6 +194,12 @@ export function splitGroupingSetsResult(
  *   - intermediate column prefix         -> column subtotal       -> colSubTotals
  * A full-length prefix (the leaf level) is always emitted; when a dimension
  * list is empty, `[]` *is* the full level and is therefore always kept.
+ *
+ * A "% of row/column/grand total" `showValuesAs` selection needs its
+ * denominator level even when the corresponding Total/subtotal display
+ * toggle is off (that toggle only controls whether the totals row/column is
+ * *rendered*; see `PivotData` in `react-pivottable/utilities.ts`), so the
+ * required collapsed level(s) are forced in regardless of the toggle.
  */
 export default function buildGroupbyCombinations(
   formData: PivotTableQueryFormData,
@@ -207,14 +218,26 @@ export default function buildGroupbyCombinations(
     ...columns.map((_, i) => columns.slice(0, i + 1)),
   ];
 
+  // "% of column total" divides each cell by its column's grand total, which
+  // is computed with all rows collapsed; "% of grand total" needs the same.
+  const needsRowsCollapsed =
+    formData.showValuesAs === ShowValuesAsEnum.PERCENT_OF_COLUMN ||
+    formData.showValuesAs === ShowValuesAsEnum.PERCENT_OF_TOTAL;
+  // "% of row total" divides each cell by its row's grand total, which is
+  // computed with all columns collapsed; "% of grand total" needs the same.
+  const needsColumnsCollapsed =
+    formData.showValuesAs === ShowValuesAsEnum.PERCENT_OF_ROW ||
+    formData.showValuesAs === ShowValuesAsEnum.PERCENT_OF_TOTAL;
+
   const rowPrefixNeeded = (prefix: QueryFormColumn[]): boolean => {
     if (prefix.length === rows.length) return true; // leaf / full level
-    if (prefix.length === 0) return !!formData.colTotals; // bottom Total row
+    if (prefix.length === 0) return !!formData.colTotals || needsRowsCollapsed; // bottom Total row
     return !!formData.rowSubTotals; // row subtotal
   };
   const colPrefixNeeded = (prefix: QueryFormColumn[]): boolean => {
     if (prefix.length === columns.length) return true; // leaf / full level
-    if (prefix.length === 0) return !!formData.rowTotals; // right Total column
+    if (prefix.length === 0)
+      return !!formData.rowTotals || needsColumnsCollapsed; // right Total column
     return !!formData.colSubTotals; // column subtotal
   };
 

superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/utilities.ts

@@ -753,9 +753,18 @@ const baseAggregatorTemplates = {
           },
           format: fmtNonString(formatter),
           value() {
-            const acc = data
-              .getAggregator(...Array.from(this.selector || []))
-              .inner.value();
+            // `buildGroupbyCombinations` requests the denominator's rollup
+            // level whenever a percent `showValuesAs` is selected, but fall
+            // back to `null` (rendered blank) instead of throwing if it is
+            // ever missing -- e.g. a denominator aggregator with no matching
+            // rows in the response.
+            const denominatorAggregator = data.getAggregator(
+              ...Array.from(this.selector || []),
+            );
+            if (!denominatorAggregator.inner) {
+              return null;
+            }
+            const acc = denominatorAggregator.inner.value();
 
             if (typeof acc === 'string') {
               return acc;

superset-frontend/plugins/plugin-chart-pivot-table/src/types.ts

@@ -52,10 +52,12 @@ export enum MetricsLayoutEnum {
 
 /**
  * Display mode for pivot cell values: raw values, or each value expressed as
- * a fraction of its row/column/grand total. Purely a presentational transform
- * applied at render time against the already DB-correct rollup totals (see
- * `PivotData` in `react-pivottable/utilities.ts`); it does not change what
- * gets queried.
+ * a fraction of its row/column/grand total. The division itself is a
+ * presentational transform applied at render time against the already
+ * DB-correct rollup totals (see `PivotData` in
+ * `react-pivottable/utilities.ts`), but a percent mode does need its
+ * denominator level queried even if the corresponding Total/subtotal display
+ * toggle is off; see `buildGroupbyCombinations` in `plugin/utilities.ts`.
  */
 export enum ShowValuesAsEnum {
   ACTUAL = 'actual',

superset-frontend/plugins/plugin-chart-pivot-table/test/plugin/utilities.test.ts

@@ -26,7 +26,11 @@ import buildGroupbyCombinations, {
   splitGroupingSetsResult,
   groupingMarkerLabel,
 } from '../../src/plugin/utilities';
-import { PivotTableQueryFormData, MetricsLayoutEnum } from '../../src/types';
+import {
+  PivotTableQueryFormData,
+  MetricsLayoutEnum,
+  ShowValuesAsEnum,
+} from '../../src/types';
 
 const baseFormData = {
   groupbyRows: ['row1', 'row2'],
@@ -364,6 +368,67 @@ test('pruning: empty column dims keep the [] (leaf) level regardless of rowTotal
   ]);
 });
 
+test('pruning: percent_row forces the row-total (columns collapsed) level even with rowTotals off', () => {
+  const combinations = buildGroupbyCombinations({
+    ...baseFormData,
+    colTotals: false,
+    rowTotals: false,
+    colSubTotals: false,
+    rowSubTotals: false,
+    showValuesAs: ShowValuesAsEnum.PERCENT_OF_ROW,
+  });
+  expect(combinations).toEqual([
+    { rows: ['row1', 'row2'], columns: [] },
+    { rows: ['row1', 'row2'], columns: ['col1', 'col2'] },
+  ]);
+});
+
+test('pruning: percent_col forces the column-total (rows collapsed) level even with colTotals off', () => {
+  const combinations = buildGroupbyCombinations({
+    ...baseFormData,
+    colTotals: false,
+    rowTotals: false,
+    colSubTotals: false,
+    rowSubTotals: false,
+    showValuesAs: ShowValuesAsEnum.PERCENT_OF_COLUMN,
+  });
+  expect(combinations).toEqual([
+    { rows: [], columns: ['col1', 'col2'] },
+    { rows: ['row1', 'row2'], columns: ['col1', 'col2'] },
+  ]);
+});
+
+test('pruning: percent_total forces the grand-total level even with both totals off', () => {
+  const combinations = buildGroupbyCombinations({
+    ...baseFormData,
+    colTotals: false,
+    rowTotals: false,
+    colSubTotals: false,
+    rowSubTotals: false,
+    showValuesAs: ShowValuesAsEnum.PERCENT_OF_TOTAL,
+  });
+  expect(combinations).toEqual([
+    { rows: [], columns: [] },
+    { rows: ['row1', 'row2'], columns: [] },
+    { rows: [], columns: ['col1', 'col2'] },
+    { rows: ['row1', 'row2'], columns: ['col1', 'col2'] },
+  ]);
+});
+
+test('pruning: actual (no percent mode) does not force any extra level', () => {
+  const combinations = buildGroupbyCombinations({
+    ...baseFormData,
+    colTotals: false,
+    rowTotals: false,
+    colSubTotals: false,
+    rowSubTotals: false,
+    showValuesAs: ShowValuesAsEnum.ACTUAL,
+  });
+  expect(combinations).toEqual([
+    { rows: ['row1', 'row2'], columns: ['col1', 'col2'] },
+  ]);
+});
+
 test('additiveReducerFor maps aggregates to reducers', () => {
   const mk = (aggregate: string) =>
     ({