From d7dd855fc4dbc4b406bf99308834235f01a2702a Mon Sep 17 00:00:00 2001 From: Laszlo Bodor Date: Mon, 13 Feb 2023 17:02:35 +0100 Subject: [PATCH 1/2] TEZ-4475: VertexStatus is missing in TestLocalMode if DAG finishes too quickly - causing NPE in unit test --- .../test/java/org/apache/tez/test/TestLocalMode.java | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java b/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java index 00125fd547..a3d949e664 100644 --- a/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java +++ b/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java @@ -62,6 +62,12 @@ @RunWith(Parameterized.class) public class TestLocalMode { + /** + * In order to be able to safely get VertexStatus from a running DAG, + * the DAG needs to run for a certain amount of time, see TEZ-4475 + */ + private static final int SLEEP_PROCESSOR_TIME_TO_SLEEP_MS = 500; + private static final File STAGING_DIR = new File(System.getProperty("test.build.data"), TestLocalMode.class.getName()); @@ -255,8 +261,9 @@ public void run(Map inputs, Map out } private DAG createSimpleDAG(String dagName, String processorName) { - DAG dag = DAG.create(dagName).addVertex(Vertex.create(SleepProcessor.SLEEP_VERTEX_NAME, ProcessorDescriptor - .create(processorName).setUserPayload(new SleepProcessor.SleepProcessorConfig(1).toUserPayload()), 1)); + DAG dag = DAG.create(dagName).addVertex( + Vertex.create(SleepProcessor.SLEEP_VERTEX_NAME, ProcessorDescriptor.create(processorName).setUserPayload( + new SleepProcessor.SleepProcessorConfig(SLEEP_PROCESSOR_TIME_TO_SLEEP_MS).toUserPayload()), 1)); return dag; } From d3098648c9bc8cebd99a8530b643af86f28ab978 Mon Sep 17 00:00:00 2001 From: Laszlo Bodor Date: Tue, 14 Feb 2023 09:08:34 +0100 Subject: [PATCH 2/2] checkstyle --- tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java b/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java index a3d949e664..14832d36cf 100644 --- a/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java +++ b/tez-tests/src/test/java/org/apache/tez/test/TestLocalMode.java @@ -64,7 +64,7 @@ public class TestLocalMode { /** * In order to be able to safely get VertexStatus from a running DAG, - * the DAG needs to run for a certain amount of time, see TEZ-4475 + * the DAG needs to run for a certain amount of time, see TEZ-4475 for details. */ private static final int SLEEP_PROCESSOR_TIME_TO_SLEEP_MS = 500;