Skip to content

Check state of HostDBInfo#12880

Merged
masaori335 merged 3 commits into
apache:masterfrom
masaori335:asf-master-hostdb-single-info
Feb 23, 2026
Merged

Check state of HostDBInfo#12880
masaori335 merged 3 commits into
apache:masterfrom
masaori335:asf-master-hostdb-single-info

Conversation

@masaori335
Copy link
Copy Markdown
Contributor

HostDBRecord::select_best_http() function is expected return nullptr is all HostDBInfo are down state. However, a HostDBRecord has only one HostDBInfo (info.count() == 1), state of the info is not checked.

@masaori335 masaori335 added this to the 10.2.0 milestone Feb 12, 2026
@masaori335 masaori335 self-assigned this Feb 12, 2026
@masaori335
Copy link
Copy Markdown
Contributor Author

Test: dns_host_down: Failed seems related to this change. I'll check it in local.

@masaori335 masaori335 marked this pull request as draft February 12, 2026 22:44
@masaori335 masaori335 force-pushed the asf-master-hostdb-single-info branch from 7493955 to 5c10920 Compare February 16, 2026 02:46
@masaori335
Copy link
Copy Markdown
Contributor Author

The dns_host_down AuTest is adjusted.

@masaori335 masaori335 marked this pull request as ready for review February 16, 2026 05:02
Comment thread src/iocore/hostdb/HostDB.cc Outdated
@bneradt
Copy link
Copy Markdown
Contributor

bneradt commented Feb 19, 2026

[approve ci autest]

@bryancall bryancall modified the milestones: 10.2.0, 11.0.0 Feb 23, 2026
@bryancall bryancall added the Bug label Feb 23, 2026
@masaori335 masaori335 merged commit bc464c5 into apache:master Feb 23, 2026
15 checks passed
@github-project-automation github-project-automation Bot moved this to For v10.2.0 in ATS v10.2.x Feb 23, 2026
@masaori335 masaori335 removed this from ATS v10.2.x Feb 24, 2026
@masaori335
Copy link
Copy Markdown
Contributor Author

masaori335 commented Feb 24, 2026

I just noticed #11814 intentionally restored the ATS9 behavior for 10.0.x.

If a HostDB record only has one IP, always select that for use/retry regardless of fail status (This restores the ATS9 behavior)

We need to figure out where this should go.

@github-project-automation github-project-automation Bot moved this to For v10.2.0 in ATS v10.2.x Feb 25, 2026
@masaori335
Copy link
Copy Markdown
Contributor Author

masaori335 commented Feb 25, 2026

Talked with @cmcfarlen, it seems good to ship this by 10.2.0 as a bug fix.

If anybody wants to try connect attempt against down servers, below changes are recommended

@cmcfarlen cmcfarlen moved this from For v10.2.0 to Picked v10.2.0 in ATS v10.2.x Mar 2, 2026
@cmcfarlen cmcfarlen modified the milestones: 11.0.0, 10.2.0 Mar 2, 2026
@cmcfarlen
Copy link
Copy Markdown
Contributor

Cherry-picked to 10.2.x

cmcfarlen pushed a commit that referenced this pull request Mar 2, 2026
* Check state of HostDBInfo

* Adjust AuTest

* Cleanup: use select function for consistency

(cherry picked from commit bc464c5)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Picked v10.2.0

Development

Successfully merging this pull request may close these issues.

5 participants