Add test for [skip ci] in commit but not PR title

Author: driazati

tests/python/unittest/test_ci.py

@@ -37,7 +37,7 @@ def run(self, *args):
             if proc.returncode != 0:
                 raise RuntimeError(f"git command failed: '{args}'")
 
-    def test(commands, should_skip, why):
+    def test(commands, should_skip, pr_title, why):
         with tempfile.TemporaryDirectory() as dir:
             git = TempGit(dir)
             # Jenkins git is too old and doesn't have 'git init --initial-branch'
@@ -51,14 +51,15 @@ def test(commands, should_skip, why):
                 git.run(*command)
             pr_number = "1234"
             proc = subprocess.run(
-                [str(skip_ci_script), "--pr", pr_number, "--pr-title", "[skip ci] test"], cwd=dir
+                [str(skip_ci_script), "--pr", pr_number, "--pr-title", pr_title], cwd=dir
             )
             expected = 0 if should_skip else 1
             assert proc.returncode == expected, why
 
     test(
         commands=[],
         should_skip=False,
+        pr_title="[skip ci] test",
         why="ci should not be skipped",
     )
 
@@ -67,6 +68,7 @@ def test(commands, should_skip, why):
             ["commit", "--allow-empty", "--message", "[skip ci] commit 1"],
         ],
         should_skip=False,
+        pr_title="[skip ci] test",
         why="ci should not be skipped on main",
     )
 
@@ -76,16 +78,28 @@ def test(commands, should_skip, why):
             ["commit", "--allow-empty", "--message", "[skip ci] commit 1"],
         ],
         should_skip=True,
+        pr_title="[skip ci] test",
         why="ci should be skipped on a branch with [skip ci] in the last commit",
     )
 
+    test(
+        commands=[
+            ["checkout", "-b", "some_new_branch"],
+            ["commit", "--allow-empty", "--message", "[skip ci] commit 1"],
+        ],
+        should_skip=False,
+        pr_title="[no skip ci] test",
+        why="ci should not be skipped on a branch with [skip ci] in the last commit but not the PR title",
+    )
+
     test(
         commands=[
             ["checkout", "-b", "some_new_branch"],
             ["commit", "--allow-empty", "--message", "[skip ci] commit 1"],
             ["commit", "--allow-empty", "--message", "commit 2"],
         ],
         should_skip=False,
+        pr_title="[skip ci] test",
         why="ci should not be skipped on a branch without [skip ci] in the last commit",
     )
 
@@ -96,6 +110,7 @@ def test(commands, should_skip, why):
             ["commit", "--allow-empty", "--message", "commit 2"],
         ],
         should_skip=False,
+        pr_title="[skip ci] test",
         why="ci should not be skipped on a branch without [skip ci] in the last commit",
     )
 
@@ -108,6 +123,7 @@ def test(commands, should_skip, why):
             ["commit", "--allow-empty", "--message", "commit 4"],
         ],
         should_skip=False,
+        pr_title="[skip ci] test",
         why="ci should not be skipped on a branch without [skip ci] in the last commit",
     )