From b896935d30ad38407045a58de7d4ec310111e272 Mon Sep 17 00:00:00 2001 From: Wuwei Lin Date: Wed, 14 Aug 2024 16:12:33 -0700 Subject: [PATCH] [Disco] Fix double free of nccl communicator --- src/runtime/disco/nccl/nccl_context.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/runtime/disco/nccl/nccl_context.h b/src/runtime/disco/nccl/nccl_context.h index 730479b61ac0..b874da219fe4 100644 --- a/src/runtime/disco/nccl/nccl_context.h +++ b/src/runtime/disco/nccl/nccl_context.h @@ -129,6 +129,9 @@ struct CCLThreadLocalContext { void Clear() { if (group_comm) { NCCL_CALL(ncclCommDestroy(group_comm)); + if (global_comm == group_comm) { + global_comm = nullptr; + } group_comm = nullptr; } if (global_comm) {