From 4372f491194038556b9ed6c91236edbdec044615 Mon Sep 17 00:00:00 2001 From: System Administrator Date: Thu, 16 Jun 2016 03:45:27 -0700 Subject: [PATCH 1/3] remove suggestion list on click --- zeppelin-web/src/app/notebook/notebook.controller.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js index 32c659f33ee..360c2917565 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.js @@ -879,6 +879,7 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', // function to find suggestion list on change $scope.search = function(role) { + $('.userlist').show(); convertToArray(role); checkPreviousRole(role); getChangedIndex(); @@ -950,5 +951,8 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', $scope.suggestions = []; }; +$(document).click(function(){ + $('.userlist').hide(); +}); }); From c9ef56cf3e34f8cc9ddcba1034a56df59bd48ce1 Mon Sep 17 00:00:00 2001 From: suvam97 Date: Fri, 17 Jun 2016 05:23:27 -0700 Subject: [PATCH 2/3] add angular.element in place of $ --- zeppelin-web/src/app/notebook/notebook.controller.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js index 360c2917565..5a9df58379a 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.js @@ -951,7 +951,7 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', $scope.suggestions = []; }; -$(document).click(function(){ +angular.element(document).click(function(){ $('.userlist').hide(); }); From 29870cd94631476677aac8a17cfa28a34a9c29e2 Mon Sep 17 00:00:00 2001 From: suvam97 Date: Sat, 18 Jun 2016 08:37:46 -0700 Subject: [PATCH 3/3] changed $ to angular.element --- zeppelin-web/src/app/notebook/notebook.controller.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zeppelin-web/src/app/notebook/notebook.controller.js b/zeppelin-web/src/app/notebook/notebook.controller.js index 5a9df58379a..944402a2f3a 100644 --- a/zeppelin-web/src/app/notebook/notebook.controller.js +++ b/zeppelin-web/src/app/notebook/notebook.controller.js @@ -879,7 +879,7 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', // function to find suggestion list on change $scope.search = function(role) { - $('.userlist').show(); + angular.element('.userlist').show(); convertToArray(role); checkPreviousRole(role); getChangedIndex(); @@ -952,7 +952,7 @@ angular.module('zeppelinWebApp').controller('NotebookCtrl', }; angular.element(document).click(function(){ - $('.userlist').hide(); + angular.element('.userlist').hide(); }); });