[ZEPPELIN-1085] Make dropdown menu scrollbar always visible#1143
Closed
AhyoungRyu wants to merge 1 commit into
Closed
[ZEPPELIN-1085] Make dropdown menu scrollbar always visible#1143AhyoungRyu wants to merge 1 commit into
AhyoungRyu wants to merge 1 commit into
Conversation
Contributor
Author
|
@jeffsteinmetz It will be appreciate if you can review this PR as a reporter of this issue :) |
Member
|
Thanks @AhyoungRyu for improvement. |
Contributor
|
LGTM |
Contributor
|
LGTM Tested with:
|
Member
|
Merge it into master if there is no more discussion |
Contributor
Author
|
@jeffsteinmetz Right. So Firefox users can know they can scroll down and there is more menus even though this PR couldn't be applied to Firefox. |
asfgit
pushed a commit
that referenced
this pull request
Jul 18, 2016
### What is this PR for? In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in #1004. Originally the scroll bar is shown up when a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu. See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085). So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x). In short, it says >There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences). ### What type of PR is it? Improvement ### TODO - [x] : test this in major browsers ### What is the Jira issue? [ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085) ### How should this be tested? [Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu. ### Screenshots (if appropriate) - Before : scrollbar is only shown up when you are trying to scroll up & down  - After : always visible  - In case of IE, you can always see the scrollbar. So it's not a problem originally.  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <fbdkdud93@hanmail.net> Closes #1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits: 4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible (cherry picked from commit 1ccbd60) Signed-off-by: Mina Lee <minalee@apache.org>
PhilippGrulich
pushed a commit
to SWC-SENSE/zeppelin
that referenced
this pull request
Aug 8, 2016
### What is this PR for? In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in apache#1004. Originally the scroll bar is shown up when a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu. See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085). So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x). In short, it says >There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences). ### What type of PR is it? Improvement ### TODO - [x] : test this in major browsers ### What is the Jira issue? [ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085) ### How should this be tested? [Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu. ### Screenshots (if appropriate) - Before : scrollbar is only shown up when you are trying to scroll up & down  - After : always visible  - In case of IE, you can always see the scrollbar. So it's not a problem originally.  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no Author: AhyoungRyu <fbdkdud93@hanmail.net> Closes apache#1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits: 4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR for?
In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially Interpreters and More menu have lots of lists so I made this dropdown menu scrollable in #1004.
Originally the scroll bar is shown up when a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu. See this issue.
So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See here.
In short, it says
What type of PR is it?
Improvement
TODO
What is the Jira issue?
ZEPPELIN-1085
How should this be tested?
Build the Zeppelin docs website in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click Interpreters or More menu.
Screenshots (if appropriate)
Questions: