Skip to content

[ZEPPELIN-1085] Make dropdown menu scrollbar always visible#1143

Closed
AhyoungRyu wants to merge 1 commit into
apache:masterfrom
AhyoungRyu:ZEPPELIN-1085
Closed

[ZEPPELIN-1085] Make dropdown menu scrollbar always visible#1143
AhyoungRyu wants to merge 1 commit into
apache:masterfrom
AhyoungRyu:ZEPPELIN-1085

Conversation

@AhyoungRyu
Copy link
Copy Markdown
Contributor

@AhyoungRyu AhyoungRyu commented Jul 7, 2016

What is this PR for?

In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially Interpreters and More menu have lots of lists so I made this dropdown menu scrollable in #1004.
Originally the scroll bar is shown up when a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu. See this issue.

So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See here.
In short, it says

There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences).

What type of PR is it?

Improvement

TODO

  • : test this in major browsers

What is the Jira issue?

ZEPPELIN-1085

How should this be tested?

Build the Zeppelin docs website in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click Interpreters or More menu.

Screenshots (if appropriate)

  • Before : scrollbar is only shown up when you are trying to scroll up & down
    before
  • After : always visible
    after
  • In case of IE, you can always see the scrollbar. So it's not a problem originally.
    screen shot 2016-07-07 at 5 41 27 pm

Questions:

  • Does the licenses files need update? no
  • Is there breaking changes for older versions? no
  • Does this needs documentation? no

@AhyoungRyu
Copy link
Copy Markdown
Contributor Author

@jeffsteinmetz It will be appreciate if you can review this PR as a reporter of this issue :)

@Leemoonsoo
Copy link
Copy Markdown
Member

Thanks @AhyoungRyu for improvement.
Tested with Chrome and Safari. LGTM

@prabhjyotsingh
Copy link
Copy Markdown
Contributor

LGTM

@jeffsteinmetz
Copy link
Copy Markdown
Contributor

LGTM
At least in Firefox, the scroll bar now displays for a few seconds (doesn't stay, but its an improvement).
Chrome and Safari work as expected.

Tested with:

  • Chrome on OSX: Version 51.0.2704.103 (64-bit)
  • Safari: Version 9.1.1 (10601.6.17)
  • Firefox on OSX: 47.0.1

@Leemoonsoo
Copy link
Copy Markdown
Member

Merge it into master if there is no more discussion

@AhyoungRyu
Copy link
Copy Markdown
Contributor Author

@jeffsteinmetz Right. So Firefox users can know they can scroll down and there is more menus even though this PR couldn't be applied to Firefox.
Thanks for testing this @Leemoonsoo @jeffsteinmetz :)

@asfgit asfgit closed this in 1ccbd60 Jul 9, 2016
asfgit pushed a commit that referenced this pull request Jul 18, 2016
### What is this PR for?
In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in #1004.
Originally the scroll bar is shown up when  a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu.  See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085).

So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x).
In short, it says
>There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences).

### What type of PR is it?
Improvement

### TODO
- [x] : test this in major browsers

### What is the Jira issue?
[ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085)

### How should this be tested?
[Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu.

### Screenshots (if appropriate)
 - Before : scrollbar is only shown up when you are trying to scroll up & down
![before](https://cloud.githubusercontent.com/assets/10060731/16647507/8c6fbc60-446a-11e6-9a57-b00a76e6b59c.gif)

 - After : always visible
![after](https://cloud.githubusercontent.com/assets/10060731/16647513/901e4e3a-446a-11e6-840b-599b6121fe46.gif)

 - In case of IE, you can always see the scrollbar. So it's not a problem originally.
![screen shot 2016-07-07 at 5 41 27 pm](https://cloud.githubusercontent.com/assets/10060731/16647584/e3708ff8-446a-11e6-8aee-c03eaba70cc9.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <fbdkdud93@hanmail.net>

Closes #1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits:

4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible

(cherry picked from commit 1ccbd60)
Signed-off-by: Mina Lee <minalee@apache.org>
PhilippGrulich pushed a commit to SWC-SENSE/zeppelin that referenced this pull request Aug 8, 2016
### What is this PR for?
In Zeppelin docs website, there are 4 dropdown menus(Quick Start, Interpreters, Display System and More) in the navbar. Especially **Interpreters** and **More** menu have lots of lists so I made this dropdown menu scrollable in apache#1004.
Originally the scroll bar is shown up when  a user is trying to scroll down. That's why it's hard to notice there are more menus in the dropdown menu.  See [this issue](https://issues.apache.org/jira/browse/ZEPPELIN-1085).

So I made this scroll bar always visible. But only for chrome & safari. Unfortunately, Firefox doesn't support custom scroll bar. See [here](http://stackoverflow.com/questions/18317634/force-visible-scrollbar-in-firefox-on-mac-os-x).
In short, it says
>There is no way to actually "force" Firefox render the old-style scrollbar since the default scrollbar used in the system is predefined by the OS itself (note that you can modify which scrollbar you want in System Preferences).

### What type of PR is it?
Improvement

### TODO
- [x] : test this in major browsers

### What is the Jira issue?
[ZEPPELIN-1085](https://issues.apache.org/jira/browse/ZEPPELIN-1085)

### How should this be tested?
[Build the Zeppelin docs website](https://github.com/apache/zeppelin/tree/master/docs#build-documentation) in your local and check the dropdown menu in navbar. The scrollbae has to be shown right after you click **Interpreters** or **More** menu.

### Screenshots (if appropriate)
 - Before : scrollbar is only shown up when you are trying to scroll up & down
![before](https://cloud.githubusercontent.com/assets/10060731/16647507/8c6fbc60-446a-11e6-9a57-b00a76e6b59c.gif)

 - After : always visible
![after](https://cloud.githubusercontent.com/assets/10060731/16647513/901e4e3a-446a-11e6-840b-599b6121fe46.gif)

 - In case of IE, you can always see the scrollbar. So it's not a problem originally.
![screen shot 2016-07-07 at 5 41 27 pm](https://cloud.githubusercontent.com/assets/10060731/16647584/e3708ff8-446a-11e6-8aee-c03eaba70cc9.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu <fbdkdud93@hanmail.net>

Closes apache#1143 from AhyoungRyu/ZEPPELIN-1085 and squashes the following commits:

4d10883 [AhyoungRyu] Make dropdown menu scrollbar always visible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants