From 0badf282fb02d4229ce3f476ffb157eb7dcc1c69 Mon Sep 17 00:00:00 2001 From: Rick Moritz Date: Fri, 16 Oct 2015 16:52:38 +0200 Subject: [PATCH] ZEPPELIN-346 Fix NotebookTest not passing non-default group to NoteInterpreterLoader This implements the actually required logic for this test to pass and should mostly showcase that the NoteIntepreterLoader logic is flawed/broken. Nonetheless this would fix the test in the short term and be a step towards actually documenting the weird behaviour. I will try to amend this PR (or create a separate one) to actually approach the underlying issue --- .../test/java/org/apache/zeppelin/notebook/NotebookTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java index 883dc64b714..61f3f0ff03d 100644 --- a/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java +++ b/zeppelin-zengine/src/test/java/org/apache/zeppelin/notebook/NotebookTest.java @@ -73,7 +73,7 @@ public void setUp() throws Exception { this.schedulerFactory = new SchedulerFactory(); MockInterpreter1.register("mock1", "org.apache.zeppelin.interpreter.mock.MockInterpreter1"); - MockInterpreter2.register("mock2", "org.apache.zeppelin.interpreter.mock.MockInterpreter2"); + MockInterpreter2.register("mock2", "group2", "org.apache.zeppelin.interpreter.mock.MockInterpreter2"); factory = new InterpreterFactory(conf, new InterpreterOption(false), null); @@ -100,7 +100,7 @@ public void testSelectingReplImplementation() throws IOException { // run with specific repl Paragraph p2 = note.addParagraph(); - p2.setText("%mock2 hello world"); + p2.setText("%group2.mock2 hello world"); note.run(p2.getId()); while(p2.isTerminated()==false || p2.getResult()==null) Thread.yield(); assertEquals("repl2: hello world", p2.getResult().message());