From 548f577a07fd82a1639d972ab8f1f59d27cb7a04 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?K=C3=A9vin=20Dunglas?= Date: Mon, 8 May 2017 19:01:02 +0200 Subject: [PATCH 1/2] Upgrade the Negotiation library --- composer.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/composer.json b/composer.json index 37e2df85a3d..85c3dc08ffa 100644 --- a/composer.json +++ b/composer.json @@ -22,7 +22,7 @@ "symfony/property-access": "^2.7 || ^3.0", "symfony/property-info": "^3.1", "symfony/serializer": "^3.1", - "willdurand/negotiation": "^2.0.3 <2.3" + "willdurand/negotiation": "^2.3.1" }, "require-dev": { "behat/behat": "^3.1", From babe7bbb3a4ca5c40a111cbe41ce81f309677b5d Mon Sep 17 00:00:00 2001 From: abluchet Date: Mon, 15 May 2017 11:10:51 +0200 Subject: [PATCH 2/2] fix phpstan errors --- phpstan.neon | 4 +--- .../Doctrine/Orm/Extension/FilterEagerLoadingExtension.php | 2 +- src/Bridge/Doctrine/Orm/Util/EagerLoadingTrait.php | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/phpstan.neon b/phpstan.neon index 554c48be596..8cdf4363f41 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -10,7 +10,5 @@ parameters: - '#Call to an undefined method PHPUnit_Framework_MockObject_MockObject::[a-zA-Z0-9_]+\(\)#' # False positives - - '#scalar#' # Fixed in PHPStan 0.7 - '#Parameter \#2 \$dqlPart of method Doctrine\\ORM\\QueryBuilder::add\(\) expects Doctrine\\ORM\\Query\\Expr\\Base, Doctrine\\ORM\\Query\\Expr\\Join\[\] given#' # Fixed in Doctrine's master - - '#Parameter \#1 \$rootNode of method ApiPlatform\\Core\\Bridge\\Symfony\\Bundle\\DependencyInjection\\Configuration::[a-zA-Z0-9]+\(\) expects Symfony\\Component\\Config\\Definition\\Builder\\ArrayNodeDefinition, Symfony\\Component\\Config\\Definition\\Builder\\ArrayNodeDefinition|Symfony\\Component\\Config\\Definition\\Builder\\NodeDefinition given#' - - '#Parameter \#1 \$source of static method ApiPlatform\\Core\\Util\\RequestParser::parseRequestParams\(\) expects string, string\|resource given#' + - '#Parameter \#1 \$callable of static method Doctrine\\Common\\Annotations\\AnnotationRegistry::registerLoader\(\) expects callable, mixed\[\] given#' diff --git a/src/Bridge/Doctrine/Orm/Extension/FilterEagerLoadingExtension.php b/src/Bridge/Doctrine/Orm/Extension/FilterEagerLoadingExtension.php index 71ffb802aaa..36b23f9357b 100644 --- a/src/Bridge/Doctrine/Orm/Extension/FilterEagerLoadingExtension.php +++ b/src/Bridge/Doctrine/Orm/Extension/FilterEagerLoadingExtension.php @@ -27,7 +27,7 @@ final class FilterEagerLoadingExtension implements QueryCollectionExtensionInter { use EagerLoadingTrait; - public function __construct(ResourceMetadataFactoryInterface $resourceMetadataFactory, $forceEager = true) + public function __construct(ResourceMetadataFactoryInterface $resourceMetadataFactory, bool $forceEager = true) { $this->resourceMetadataFactory = $resourceMetadataFactory; $this->forceEager = $forceEager; diff --git a/src/Bridge/Doctrine/Orm/Util/EagerLoadingTrait.php b/src/Bridge/Doctrine/Orm/Util/EagerLoadingTrait.php index 05d8a979175..712ca921d71 100644 --- a/src/Bridge/Doctrine/Orm/Util/EagerLoadingTrait.php +++ b/src/Bridge/Doctrine/Orm/Util/EagerLoadingTrait.php @@ -46,7 +46,7 @@ private function shouldOperationForceEager(string $resourceClass, array $options $forceEager = $resourceMetadata->getAttribute('force_eager'); } - return is_bool($forceEager) ? $forceEager : $this->forceEager; + return is_bool($forceEager) ? $forceEager : (bool) $this->forceEager; } /**