Skip to content

Commit bf01947

Browse files
committed
refactor(): rollback meaningless change
1 parent 5e310b7 commit bf01947

File tree

5 files changed

+19
-25
lines changed

5 files changed

+19
-25
lines changed

apollo-client/pom.xml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -97,17 +97,17 @@
9797
<artifactId>mockserver-netty</artifactId>
9898
<scope>test</scope>
9999
</dependency>
100-
<dependency>
101-
<groupId>com.github.noconnor</groupId>
102-
<artifactId>junitperf</artifactId>
103-
<scope>test</scope>
104-
<exclusions>
105-
<exclusion>
106-
<groupId>ch.qos.logback</groupId>
107-
<artifactId>logback-classic</artifactId>
108-
</exclusion>
109-
</exclusions>
110-
</dependency>
100+
<dependency>
101+
<groupId>com.github.noconnor</groupId>
102+
<artifactId>junitperf</artifactId>
103+
<scope>test</scope>
104+
<exclusions>
105+
<exclusion>
106+
<groupId>ch.qos.logback</groupId>
107+
<artifactId>logback-classic</artifactId>
108+
</exclusion>
109+
</exclusions>
110+
</dependency>
111111
<!-- end of test -->
112112
</dependencies>
113113
</project>

apollo-client/src/main/java/com/ctrip/framework/apollo/internals/ConfigManager.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,4 @@ public interface ConfigManager {
3838
* @return the config file instance for the namespace
3939
*/
4040
ConfigFile getConfigFile(String namespace, ConfigFileFormat configFileFormat);
41-
42-
4341
}

apollo-client/src/main/java/com/ctrip/framework/apollo/internals/DefaultConfigManager.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -34,15 +34,14 @@
3434
*/
3535
public class DefaultConfigManager implements ConfigManager {
3636

37-
protected Map<String, Config> m_configs = Maps.newConcurrentMap();
38-
protected Map<String, Object> m_configLocks = Maps.newConcurrentMap();
39-
protected Map<String, ConfigFile> m_configFiles = Maps.newConcurrentMap();
40-
protected Map<String, Object> m_configFileLocks = Maps.newConcurrentMap();
37+
private Map<String, Config> m_configs = Maps.newConcurrentMap();
38+
private Map<String, Object> m_configLocks = Maps.newConcurrentMap();
39+
private Map<String, ConfigFile> m_configFiles = Maps.newConcurrentMap();
40+
private Map<String, Object> m_configFileLocks = Maps.newConcurrentMap();
4141
private ConfigFactoryManager m_factoryManager;
4242

4343
public DefaultConfigManager() {
4444
m_factoryManager = ApolloInjector.getInstance(ConfigFactoryManager.class);
45-
4645
}
4746

4847
@Override
@@ -61,16 +60,15 @@ public Config getConfig(String namespace) {
6160
}
6261
}
6362
}
64-
if(!ConfigSourceType.NONE.equals(config.getSourceType())) {
65-
Tracer.logMetricsForCount(APOLLO_CLIENT_NAMESPACE_USAGE+":"+namespace);
63+
if (!ConfigSourceType.NONE.equals(config.getSourceType())) {
64+
Tracer.logMetricsForCount(APOLLO_CLIENT_NAMESPACE_USAGE + ":" + namespace);
6665
}
6766

6867
return config;
6968
}
7069

7170
@Override
72-
public ConfigFile getConfigFile(String namespace,
73-
ConfigFileFormat configFileFormat) {
71+
public ConfigFile getConfigFile(String namespace, ConfigFileFormat configFileFormat) {
7472
String namespaceFileName = String.format("%s.%s", namespace, configFileFormat.getValue());
7573
ConfigFile configFile = m_configFiles.get(namespaceFileName);
7674

apollo-client/src/main/java/com/ctrip/framework/apollo/internals/DefaultInjector.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@
4242
import com.google.inject.Singleton;
4343
import java.util.List;
4444

45-
;
46-
4745
/**
4846
* Guice injector
4947
* @author Jason Song(song_s@ctrip.com)

apollo-client/src/main/java/com/ctrip/framework/apollo/internals/RemoteConfigLongPollService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ private void doLongPollingRefresh(String appId, String cluster, String dataCente
215215
transaction.setStatus(ex);
216216
long sleepTimeInSecond = m_longPollFailSchedulePolicyInSecond.fail();
217217
if (ex.getCause() instanceof SocketTimeoutException) {
218-
Tracer.logEvent(APOLLO_CLIENT_NAMESPACE_TIMEOUT,assembleNamespaces());
218+
Tracer.logEvent(APOLLO_CLIENT_NAMESPACE_TIMEOUT, assembleNamespaces());
219219
}
220220
logger.warn(
221221
"Long polling failed, will retry in {} seconds. appId: {}, cluster: {}, namespaces: {}, long polling url: {}, reason: {}",

0 commit comments

Comments
 (0)