fix: set_value and set_text sent incorrect data (#831)

Author: eyJhb

appium/webdriver/webdriver.py

@@ -14,6 +14,7 @@
 
 # pylint: disable=too-many-lines,too-many-public-methods,too-many-statements,no-self-use
 
+import warnings
 from typing import Any, Callable, Dict, List, Optional, Tuple, TypeVar, Union
 
 from selenium import webdriver
@@ -434,6 +435,7 @@ def create_web_element(self, element_id: Union[int, str]) -> MobileWebElement:
 
     def set_value(self: T, element: MobileWebElement, value: str) -> T:
         """Set the value on an element in the application.
+        deprecated:: 2.8.1
 
         Args:
             element: the element whose value will be set
@@ -442,10 +444,14 @@ def set_value(self: T, element: MobileWebElement, value: str) -> T:
         Returns:
             `appium.webdriver.webdriver.WebDriver`: Self instance
         """
-        data = {
-            'id': element.id,
-            'value': [value],
-        }
+        warnings.warn(
+            'The "setValue" API is deprecated and will be removed in future versions. '
+            'Instead the "send_keys" API or W3C Actions can be used. '
+            'See https://github.com/appium/python-client/pull/831',
+            DeprecationWarning,
+        )
+
+        data = {'text': value}
         self.execute(Command.SET_IMMEDIATE_VALUE, data)
         return self
 

appium/webdriver/webelement.py

@@ -12,6 +12,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
+import warnings
 from typing import Callable, Dict, List, Optional, Union
 
 from selenium.webdriver.common.utils import keys_to_typing
@@ -157,6 +158,7 @@ def clear(self) -> 'WebElement':
 
     def set_text(self, keys: str = '') -> 'WebElement':
         """Sends text to the element.
+        deprecated:: 2.8.1
 
         Previous text is removed.
         Android only.
@@ -170,7 +172,14 @@ def set_text(self, keys: str = '') -> 'WebElement':
         Returns:
             `appium.webdriver.webelement.WebElement`
         """
-        data = {'id': self._id, 'value': [keys]}
+        warnings.warn(
+            'The "setText" API is deprecated and will be removed in future versions. '
+            'Instead the "send_keys" API or W3C Actions can be used. '
+            'See https://github.com/appium/python-client/pull/831',
+            DeprecationWarning,
+        )
+
+        data = {'text': keys}
         self._execute(Command.REPLACE_KEYS, data)
         return self
 
@@ -190,17 +199,22 @@ def location_in_view(self) -> Dict[str, int]:
 
     def set_value(self, value: str) -> 'WebElement':
         """Set the value on this element in the application
+        deprecated:: 2.8.1
 
         Args:
             value: The value to be set
 
         Returns:
             `appium.webdriver.webelement.WebElement`
         """
-        data = {
-            'id': self.id,
-            'value': [value],
-        }
+        warnings.warn(
+            'The "setValue" API is deprecated and will be removed in future versions. '
+            'Instead the "send_keys" API or W3C Actions can be used. '
+            'See https://github.com/appium/python-client/pull/831',
+            DeprecationWarning,
+        )
+
+        data = {'text': value}
         self._execute(Command.SET_IMMEDIATE_VALUE, data)
         return self
 

test/unit/webdriver/webelement_test.py

@@ -46,7 +46,7 @@ def test_set_value(self):
         element.set_value(value)
 
         d = get_httpretty_request_body(httpretty.last_request())
-        assert d['value'] == [value]
+        assert d['text'] == value
 
     @httpretty.activate
     def test_send_key(self):